mirror of
https://github.com/ostreedev/ostree.git
synced 2024-10-27 01:55:35 +03:00
7835fcdc68
test-pull-untrusted.sh would pass when run as root, but fail when run as testuser. It turned out that the way the files were stored in the repo when running as a testuser were different, which meant that a different .file object was chosen for corruption. Except that file turned out to be a symlink, so the echo "broke" actually just wrote to the no_such_file symlink target, thus keeping the actual symlink file's checksum the same and causing the pull-local to pass when it should have failed. [smcv: split this out of a larger commit, part of PR #231] Signed-off-by: Simon McVittie <smcv@debian.org> Closes: #232 Approved by: cgwalters
70 lines
1.9 KiB
Bash
Executable File
70 lines
1.9 KiB
Bash
Executable File
#!/bin/bash
|
|
#
|
|
# Copyright (C) 2014 Alexander Larsson <alexl@redhat.com>
|
|
#
|
|
# This library is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU Lesser General Public
|
|
# License as published by the Free Software Foundation; either
|
|
# version 2 of the License, or (at your option) any later version.
|
|
#
|
|
# This library is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
# Lesser General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU Lesser General Public
|
|
# License along with this library; if not, write to the
|
|
# Free Software Foundation, Inc., 59 Temple Place - Suite 330,
|
|
# Boston, MA 02111-1307, USA.
|
|
|
|
|
|
set -euo pipefail
|
|
|
|
. $(dirname $0)/libtest.sh
|
|
|
|
echo '1..3'
|
|
|
|
setup_test_repository "bare"
|
|
|
|
cd ${test_tmpdir}
|
|
mkdir repo2
|
|
${CMD_PREFIX} ostree --repo=repo2 init --mode="bare"
|
|
|
|
${CMD_PREFIX} ostree --repo=repo2 --untrusted pull-local repo
|
|
|
|
find repo2 -type f -links +1 | while read line; do
|
|
assert_not_reached "pull-local created hardlinks"
|
|
done
|
|
echo "ok pull-local --untrusted didn't hardlink"
|
|
|
|
# Corrupt repo
|
|
for i in ${test_tmpdir}/repo/objects/*/*.file; do
|
|
|
|
# make sure it's not a symlink
|
|
if [ -L $i ]; then
|
|
continue
|
|
fi
|
|
|
|
echo "corrupting $i"
|
|
echo "broke" >> $i
|
|
break;
|
|
done
|
|
|
|
rm -rf repo2
|
|
mkdir repo2
|
|
${CMD_PREFIX} ostree --repo=repo2 init --mode="bare"
|
|
if ${CMD_PREFIX} ostree --repo=repo2 pull-local repo; then
|
|
echo "ok trusted pull with corruption succeeded"
|
|
else
|
|
assert_not_reached "corrupted trusted pull unexpectedly succeeded!"
|
|
fi
|
|
|
|
rm -rf repo2
|
|
mkdir repo2
|
|
${CMD_PREFIX} ostree --repo=repo2 init --mode="bare"
|
|
if ${CMD_PREFIX} ostree --repo=repo2 pull-local --untrusted repo; then
|
|
assert_not_reached "corrupted untrusted pull unexpectedly failed!"
|
|
else
|
|
echo "ok untrusted pull with corruption failed"
|
|
fi
|