systemd-stable/coccinelle/debug-logging.cocci

@@
@@
(
#define DEBUG_LOGGING
&
- _unlikely_(log_get_max_level() >= LOG_DEBUG)
+ DEBUG_LOGGING
)
@@
@@
(
#define DEBUG_LOGGING
&
- log_get_max_level() >= LOG_DEBUG
+ DEBUG_LOGGING
)
tree-wide: add DEBUG_LOGGING macro that checks whether debug logging is on (#7645) This makes things a bit easier to read I think, and also makes sure we always use the _unlikely_ wrapper around it, which so far we used sometimes and other times we didn't. Let's clean that up. 2017-12-15 13:09:00 +03:00			`@@`
			`@@`
coccinelle: ignore macro transformations in the macros themselves For example, the following transformation: - sizeof(s)-1 + STRLEN(s) would replace sizeof by STRLEN even in the STRLEN macro definition itself, which generates following nonsensical patch: --- src/basic/macro.h +++ /tmp/cocci-output-8753-b50773-macro.h @@ -182,7 +182,7 @@ static inline unsigned long ALIGN_POWER2 * Contrary to strlen(), this is a constant expression. * @x: a string literal. / -#define STRLEN(x) (sizeof(""x"") - 1) +#define STRLEN(x) (STRLEN("" x "")) / * container_of - cast a member of a structure out to the containing structure Let's exclude the macro itself from the transformation to avoid this 2019-04-28 16:03:47 +03:00			`(`
			`#define DEBUG_LOGGING`
			`&`
tree-wide: add DEBUG_LOGGING macro that checks whether debug logging is on (#7645) This makes things a bit easier to read I think, and also makes sure we always use the _unlikely_ wrapper around it, which so far we used sometimes and other times we didn't. Let's clean that up. 2017-12-15 13:09:00 +03:00			`- _unlikely_(log_get_max_level() >= LOG_DEBUG)`
			`+ DEBUG_LOGGING`
coccinelle: ignore macro transformations in the macros themselves For example, the following transformation: - sizeof(s)-1 + STRLEN(s) would replace sizeof by STRLEN even in the STRLEN macro definition itself, which generates following nonsensical patch: --- src/basic/macro.h +++ /tmp/cocci-output-8753-b50773-macro.h @@ -182,7 +182,7 @@ static inline unsigned long ALIGN_POWER2 * Contrary to strlen(), this is a constant expression. * @x: a string literal. / -#define STRLEN(x) (sizeof(""x"") - 1) +#define STRLEN(x) (STRLEN("" x "")) / * container_of - cast a member of a structure out to the containing structure Let's exclude the macro itself from the transformation to avoid this 2019-04-28 16:03:47 +03:00			`)`
tree-wide: add DEBUG_LOGGING macro that checks whether debug logging is on (#7645) This makes things a bit easier to read I think, and also makes sure we always use the _unlikely_ wrapper around it, which so far we used sometimes and other times we didn't. Let's clean that up. 2017-12-15 13:09:00 +03:00			`@@`
			`@@`
coccinelle: ignore macro transformations in the macros themselves For example, the following transformation: - sizeof(s)-1 + STRLEN(s) would replace sizeof by STRLEN even in the STRLEN macro definition itself, which generates following nonsensical patch: --- src/basic/macro.h +++ /tmp/cocci-output-8753-b50773-macro.h @@ -182,7 +182,7 @@ static inline unsigned long ALIGN_POWER2 * Contrary to strlen(), this is a constant expression. * @x: a string literal. / -#define STRLEN(x) (sizeof(""x"") - 1) +#define STRLEN(x) (STRLEN("" x "")) / * container_of - cast a member of a structure out to the containing structure Let's exclude the macro itself from the transformation to avoid this 2019-04-28 16:03:47 +03:00			`(`
			`#define DEBUG_LOGGING`
			`&`
tree-wide: add DEBUG_LOGGING macro that checks whether debug logging is on (#7645) This makes things a bit easier to read I think, and also makes sure we always use the _unlikely_ wrapper around it, which so far we used sometimes and other times we didn't. Let's clean that up. 2017-12-15 13:09:00 +03:00			`- log_get_max_level() >= LOG_DEBUG`
			`+ DEBUG_LOGGING`
coccinelle: ignore macro transformations in the macros themselves For example, the following transformation: - sizeof(s)-1 + STRLEN(s) would replace sizeof by STRLEN even in the STRLEN macro definition itself, which generates following nonsensical patch: --- src/basic/macro.h +++ /tmp/cocci-output-8753-b50773-macro.h @@ -182,7 +182,7 @@ static inline unsigned long ALIGN_POWER2 * Contrary to strlen(), this is a constant expression. * @x: a string literal. / -#define STRLEN(x) (sizeof(""x"") - 1) +#define STRLEN(x) (STRLEN("" x "")) / * container_of - cast a member of a structure out to the containing structure Let's exclude the macro itself from the transformation to avoid this 2019-04-28 16:03:47 +03:00			`)`