mirror of
https://github.com/systemd/systemd-stable.git
synced 2024-10-27 01:55:32 +03:00
Merge pull request #939 from karelzak/smatch
treewide: trivial issues detected by smatch
This commit is contained in:
commit
02d0f8a8a5
@ -818,7 +818,7 @@ static int remove_boot_efi(const char *esp_path) {
|
||||
if (r < 0)
|
||||
return log_error_errno(errno, "Failed to remove \"%s/%s\": %m", p, de->d_name);
|
||||
|
||||
log_info("Removed \"%s/\%s\".", p, de->d_name);
|
||||
log_info("Removed \"%s/%s\".", p, de->d_name);
|
||||
}
|
||||
|
||||
c++;
|
||||
|
@ -501,7 +501,7 @@ static int netlink_message_read_internal(sd_netlink_message *m, unsigned short t
|
||||
assert_return(m, -EINVAL);
|
||||
assert_return(m->sealed, -EPERM);
|
||||
assert_return(data, -EINVAL);
|
||||
assert(m->n_containers <= RTNL_CONTAINER_DEPTH);
|
||||
assert(m->n_containers < RTNL_CONTAINER_DEPTH);
|
||||
assert(m->containers[m->n_containers].attributes);
|
||||
assert(type < m->containers[m->n_containers].n_attributes);
|
||||
|
||||
|
@ -379,13 +379,14 @@ struct udev_ctrl_msg *udev_ctrl_receive_msg(struct udev_ctrl_connection *conn) {
|
||||
cmsg_close_all(&smsg);
|
||||
|
||||
cmsg = CMSG_FIRSTHDR(&smsg);
|
||||
cred = (struct ucred *) CMSG_DATA(cmsg);
|
||||
|
||||
if (cmsg == NULL || cmsg->cmsg_type != SCM_CREDENTIALS) {
|
||||
log_error("no sender credentials received, message ignored");
|
||||
goto err;
|
||||
}
|
||||
|
||||
cred = (struct ucred *) CMSG_DATA(cmsg);
|
||||
|
||||
if (cred->uid != 0) {
|
||||
log_error("sender uid="UID_FMT", message ignored", cred->uid);
|
||||
goto err;
|
||||
|
Loading…
Reference in New Issue
Block a user