shaba/systemd-stable
1
1
Fork 0
mirror of https://github.com/systemd/systemd-stable.git synced 2025-01-27 14:03:43 +03:00
Code

service: minor change in service_load_pid_file return value

Browse Source 
Return 0 only if the PID was really loaded. If no PIDFile= is defined,
return -ENOENT.

Only one caller cares about the return value of this function and this
change makes the usage nicer.
This commit is contained in:
Michal Schmidt 2011-09-21 02:25:17 +02:00
parent 0d60602c3b
commit 13230d5d3c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/service.c
View File

@ -1270,7 +1270,7 @@ static int service_load_pid_file(Service *s) {
assert(s);
if (!s->pid_file)
return 0;
return -ENOENT;
if ((r = read_one_line_file(s->pid_file, &k)) < 0)
return r;
@ -2585,7 +2585,7 @@ static void service_sigchld_event(Unit *u, pid_t pid, int code, int status) {
/* Forking services may occasionally move to a new PID.
* As long as they update the PID file before exiting the old
* PID, they're fine. */
if (s->pid_file && service_load_pid_file(s) == 0)
if (service_load_pid_file(s) == 0)
return;
s->main_pid = 0;