shaba/systemd-stable
1
1
Fork 0
mirror of https://github.com/systemd/systemd-stable.git synced 2025-02-16 09:57:26 +03:00
Code

udev: exclude MD from block device ownership event locking

Browse Source 
MD instantiates devices at open(). This is incomptible with the
locking logic, as the "change" event emitted when stopping a
device will bring it back.
This commit is contained in:
Kay Sievers 2014-07-24 23:37:35 +02:00
parent fa94c34b08
commit 2e5b17d013
1 changed files with 7 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/udev/udevd.c
View File

@ -285,26 +285,17 @@ static void worker_new(struct event *event)
udev_event->exec_delay = exec_delay;
/*
* Take a "read lock" on the device node; this establishes
* Take a shared lock on the device node; this establishes
* a concept of device "ownership" to serialize device
* access. External processes holding a "write lock" will
* access. External processes holding an exclusive lock will
* cause udev to skip the event handling; in the case udev
* acquired the lock, the external process will block until
* acquired the lock, the external process can block until
* udev has finished its event handling.
*/
/*
* <kabi_> since we make check - device seems unused - we try
* ioctl to deactivate - and device is found to be opened
* <kay> sure, you try to take a write lock
* <kay> if you get it udev is out
* <kay> if you can't get it, udev is busy
* <kabi_> we cannot deactivate openned device (as it is in-use)
* <kay> maybe we should just exclude dm from that thing entirely
* <kabi_> IMHO this sounds like a good plan for this moment
*/
if (streq_ptr("block", udev_device_get_subsystem(dev)) &&
!startswith(udev_device_get_sysname(dev), "dm-")) {
if (!streq_ptr(udev_device_get_action(dev), "remove") &&
streq_ptr("block", udev_device_get_subsystem(dev)) &&
!startswith(udev_device_get_sysname(dev), "dm-") &&
!startswith(udev_device_get_sysname(dev), "md")) {
struct udev_device *d = dev;
if (streq_ptr("partition", udev_device_get_devtype(d)))