shaba/systemd-stable
1
1
Fork 0
mirror of https://github.com/systemd/systemd-stable.git synced 2024-12-23 17:34:00 +03:00
Code

network: tc/cake: do not pass 0 if OverheadBytes= is not specified

Browse Source
This commit is contained in:
Yu Watanabe 2021-11-03 04:14:08 +09:00
parent 025cd94e1c
commit 3a86a31e0c
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/network/tc/cake.c
View File

@ -49,9 +49,11 @@ static int cake_fill_message(Link *link, QDisc *qdisc, sd_netlink_message *req)
return log_link_error_errno(link, r, "Could not append TCA_CAKE_AUTORATE attribute: %m");
}
r = sd_netlink_message_append_s32(req, TCA_CAKE_OVERHEAD, c->overhead);
if (r < 0)
return log_link_error_errno(link, r, "Could not append TCA_CAKE_OVERHEAD attribute: %m");
if (c->overhead_set) {
r = sd_netlink_message_append_s32(req, TCA_CAKE_OVERHEAD, c->overhead);
if (r < 0)
return log_link_error_errno(link, r, "Could not append TCA_CAKE_OVERHEAD attribute: %m");
}
r = sd_netlink_message_close_container(req);
if (r < 0)
@ -150,7 +152,7 @@ int config_parse_cake_overhead(
c = CAKE(qdisc);
if (isempty(rvalue)) {
c->overhead = 0;
c->overhead_set = false;
TAKE_PTR(qdisc);
return 0;
}
@ -170,6 +172,7 @@ int config_parse_cake_overhead(
}
c->overhead = v;
c->overhead_set = true;
TAKE_PTR(qdisc);
return 0;
}

1
src/network/tc/cake.h
View File

@ -13,6 +13,7 @@ typedef struct CommonApplicationsKeptEnhanced {
uint64_t bandwidth;
/* Overhead compensation parameters */
bool overhead_set;
int overhead;
} CommonApplicationsKeptEnhanced;