shaba/systemd-stable
1
1
Fork 0
mirror of https://github.com/systemd/systemd-stable.git synced 2024-12-22 13:33:56 +03:00
Code

CODING_STYLE: split out section about deadlocks

Browse Source
This commit is contained in:
Lennart Poettering 2019-04-12 16:50:24 +02:00
parent 96f6cfbf62
commit 3b75e079a8
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
docs/CODING_STYLE.md
View File

@ -73,14 +73,6 @@ title: Coding Style
- To minimize strict aliasing violations, we prefer unions over casting. - To minimize strict aliasing violations, we prefer unions over casting.
- Do not issue NSS requests (that includes user name and host name
lookups) from PID 1 as this might trigger deadlocks when those
lookups involve synchronously talking to services that we would need
to start up.
- Do not synchronously talk to any other service from PID 1, due to
risk of deadlocks.
- Be exceptionally careful when formatting and parsing floating point - Be exceptionally careful when formatting and parsing floating point
numbers. Their syntax is locale dependent (i.e. `5.000` in en_US is numbers. Their syntax is locale dependent (i.e. `5.000` in en_US is
generally understood as 5, while in de_DE as 5000.). generally understood as 5, while in de_DE as 5000.).
@ -419,6 +411,15 @@ title: Coding Style
headers (i.e those in `src/systemd/sd-*.h`) use integers after all, as `bool` headers (i.e those in `src/systemd/sd-*.h`) use integers after all, as `bool`
is C99 and in our public APIs we try to stick to C89 (with a few extension). is C99 and in our public APIs we try to stick to C89 (with a few extension).
## Deadlocks
- Do not issue NSS requests (that includes user name and host name lookups)
from PID 1 as this might trigger deadlocks when those lookups involve
synchronously talking to services that we would need to start up.
- Do not synchronously talk to any other service from PID 1, due to risk of
deadlocks.
## File Descriptors ## File Descriptors
- When you allocate a file descriptor, it should be made `O_CLOEXEC` right from - When you allocate a file descriptor, it should be made `O_CLOEXEC` right from