From 693ad298e97a99b1fecdceed72efbeb8b6e0c3a2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= <zbyszek@in.waw.pl>
Date: Fri, 20 Mar 2020 19:09:35 +0100
Subject: [PATCH] test: perform partial cleanup after each test is run
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This causes the unprivileged-nspawn-root directory to be removed
after running one test. The advantage is that we reduce the maximum
disk-space use quite a bit (47*400 MB → about 18GB).
---
 test/run-integration-tests.sh |  2 +-
 test/test-functions           | 14 +++++++++++++-
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/test/run-integration-tests.sh b/test/run-integration-tests.sh
index 19b5fe0315..bcbbb8b7ed 100755
--- a/test/run-integration-tests.sh
+++ b/test/run-integration-tests.sh
@@ -6,7 +6,7 @@ if [ $# -gt 0 ]; then
     args="$@"
     do_clean=0
 else
-    args="setup run"
+    args="setup run clean-again"
     do_clean=1
 fi
 
diff --git a/test/test-functions b/test/test-functions
index d1595fcd60..732e25a8b2 100644
--- a/test/test-functions
+++ b/test/test-functions
@@ -1104,6 +1104,8 @@ setup_nspawn_root() {
         exit 1
     fi
 
+    rm -rf "$TESTDIR/unprivileged-nspawn-root"
+
     if [[ "$RUN_IN_UNPRIVILEGED_CONTAINER" = "yes" ]]; then
         ddebug "cp -ar $initdir $TESTDIR/unprivileged-nspawn-root"
         cp -ar $initdir $TESTDIR/unprivileged-nspawn-root
@@ -1936,6 +1938,12 @@ test_cleanup() {
     _test_cleanup
 }
 
+test_cleanup_again() {
+    [ -n "$TESTDIR" ] || return
+    rm -rf "$TESTDIR/unprivileged-nspawn-root"
+    umount_initdir
+}
+
 test_create_image() {
     create_empty_image_rootdir
 
@@ -2039,10 +2047,14 @@ do_test() {
                 test_setup
                 test_setup_cleanup
                 ;;
-            --clean|--clean-again)
+            --clean)
                 echo "TEST CLEANUP: $TEST_DESCRIPTION"
                 test_cleanup
                 ;;
+            --clean-again)
+                echo "TEST CLEANUP AGAIN: $TEST_DESCRIPTION"
+                test_cleanup_again
+                ;;
             --all)
                 ret=0
                 echo -n "TEST: $TEST_DESCRIPTION "