From 9d41c62f6eeb50334e155e1f788e132d55d0c8c1 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Tue, 5 Apr 2022 10:19:20 +0200 Subject: [PATCH] sd-device: validate devnum parameters in device_set_devnum() --- src/libsystemd/sd-device/sd-device.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/libsystemd/sd-device/sd-device.c b/src/libsystemd/sd-device/sd-device.c index f9c491c242..d31526fc22 100644 --- a/src/libsystemd/sd-device/sd-device.c +++ b/src/libsystemd/sd-device/sd-device.c @@ -585,11 +585,15 @@ int device_set_devnum(sd_device *device, const char *major, const char *minor) { return r; if (maj == 0) return 0; + if (!DEVICE_MAJOR_VALID(maj)) + return -EINVAL; if (minor) { r = safe_atou(minor, &min); if (r < 0) return r; + if (!DEVICE_MINOR_VALID(min)) + return -EINVAL; } r = device_add_property_internal(device, "MAJOR", major);