From b82e818f5cc919187630bce88fc5d5ded0f51d23 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Tue, 19 Nov 2019 18:54:47 +0100 Subject: [PATCH] test: make sure our tests get exclusive TTY access This sould make our test suite a bit more robust if it is slow running. A few of our test services use StandardOutput=tty or StandardError=tty in the tests in order to connect test services to the container console. This gets into conflict with the container getty which wants exclusive access to the console. Since the container getty is started with Type=idle it typically gets started after a timeout only if the TTY is already used, which hence introduces a race: if the test finishes earlier all is good, if not, then the test gets kicked off the TTY which then causes bash to abort since it cannot write any error messages anymore. Let's fix this hence: all tests that connect to the tty are now synchronized to getty-pre.target, so they finish before any getty is started. --- test/TEST-20-MAINPIDGAMES/test.sh | 2 ++ test/TEST-22-TMPFILES/testsuite.service | 2 ++ test/TEST-42-EXECSTOPPOST/test.sh | 2 ++ 3 files changed, 6 insertions(+) diff --git a/test/TEST-20-MAINPIDGAMES/test.sh b/test/TEST-20-MAINPIDGAMES/test.sh index 0ba30bdb00..05fa847a65 100755 --- a/test/TEST-20-MAINPIDGAMES/test.sh +++ b/test/TEST-20-MAINPIDGAMES/test.sh @@ -18,6 +18,8 @@ test_setup() { cat >$initdir/etc/systemd/system/testsuite.service <$initdir/etc/systemd/system/testsuite.service <