mirror of
https://github.com/systemd/systemd-stable.git
synced 2024-12-22 13:33:56 +03:00
efi: drop executable-stack bit from .elf file
An rpminspect test in Fedora/RHEL is flagging our stub files as having an executable stack. The check is correct: $ readelf --wide --program-headers build/src/boot/efi/linuxx64.elf.stub | rg -i stack GNU_STACK 0x000000 0x0000000000000000 0x0000000000000000 0x000000 0x000000 RWE 0x10 It seems to be just an omission in the linker script… None of the objects that are linked into the stub are marked as requiring an executable stack: $ readelf --wide --sections build/src/boot/efi/*.c.o \ /usr/lib/gnuefi/x64/libgnuefi.a \ /usr/lib/gnuefi/x64/libefi.a \ /usr/lib/gcc/x86_64-redhat-linux/12/libgcc.a \ | rg '.note.GNU-stack.*X' (nothing) On aarch64 we end up with a nonexecutable stack, but on ia32 and x64 we get one, so this might be just a matter of defaults in the linker. It doesn't matter greatly, but let's mark the stack as non-executable to avoid the warning. Note: '-Wl,-z' is not needed, things work with just '-z'. (cherry picked from commit1eca770933
) (cherry picked from commit44c2ff5b1e
) (cherry picked from commit4f4344e3a5
)
This commit is contained in:
parent
73fd236311
commit
c68ae31edb
@ -265,6 +265,7 @@ efi_ldflags = [
|
|||||||
'-Wl,--warn-common',
|
'-Wl,--warn-common',
|
||||||
'-Wl,-Bsymbolic',
|
'-Wl,-Bsymbolic',
|
||||||
'-z', 'nocombreloc',
|
'-z', 'nocombreloc',
|
||||||
|
'-z', 'noexecstack',
|
||||||
efi_crt0,
|
efi_crt0,
|
||||||
]
|
]
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user