mirror of
https://github.com/systemd/systemd-stable.git
synced 2025-02-19 21:57:27 +03:00
udevd: avoid implicit memset in match_attr()
Initializing a char array to "" is equivalent to a memset() call - which is exactly what it gets compiled to. Fixing this one callsite reduced memset() _user_ cpu cycles from 2-4% to 0.05% on the EeePC. Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
This commit is contained in:
parent
e25fa4faf5
commit
cd94c04c51
@ -1794,10 +1794,11 @@ static int match_attr(struct udev_rules *rules, struct udev_device *dev, struct
|
||||
char attr[UTIL_PATH_SIZE];
|
||||
const char *key_name = &rules->buf[cur->key.attr_off];
|
||||
const char *key_value = &rules->buf[cur->key.value_off];
|
||||
char value[UTIL_NAME_SIZE] = "";
|
||||
char value[UTIL_NAME_SIZE];
|
||||
size_t len;
|
||||
|
||||
util_strlcpy(attr, key_name, sizeof(attr));
|
||||
util_strlcpy(value, "", sizeof(value));
|
||||
util_resolve_subsys_kernel(event->udev, attr, value, sizeof(value), 1);
|
||||
if (value[0] == '\0') {
|
||||
const char *val;
|
||||
|
Loading…
x
Reference in New Issue
Block a user