1
1
mirror of https://github.com/systemd/systemd-stable.git synced 2024-10-27 10:25:06 +03:00

systemctl: is-active/failed should return 0 if at least one unit is in given state

Previously we have return the not-found code, in the case that we found a
unit which does not belong to set active (resp. failed), which is the
opposite than what is written in man page.
This commit is contained in:
Lukas Nykryn 2016-01-25 15:21:28 +01:00
parent 147d3751d8
commit d60f6ad0cb

View File

@ -3153,6 +3153,7 @@ static int check_unit_generic(int code, const char *good_states, char **args) {
sd_bus *bus;
char **name;
int r;
bool found = false;
r = acquire_bus(BUS_MANAGER, &bus);
if (r < 0)
@ -3168,11 +3169,13 @@ static int check_unit_generic(int code, const char *good_states, char **args) {
state = check_one_unit(bus, *name, good_states, arg_quiet);
if (state < 0)
return state;
if (state == 0)
r = code;
if (state > 0)
found = true;
}
return r;
/* use the given return code for the case that we won't find
* any unit which matches the list */
return found ? 0 : code;
}
static int check_unit_active(int argc, char *argv[], void *userdata) {