shaba/systemd-stable
1
1
Fork 0
mirror of https://github.com/systemd/systemd-stable.git synced 2025-01-12 09:17:44 +03:00
Code

test: make pylint happy

Browse Source
This commit is contained in:
Frantisek Sumsal 2022-09-02 20:14:53 +02:00
parent 4aa84ef9a3
commit fda00958bb
1 changed files with 36 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

71
test/test-exec-deserialization.py
View File

@ -1,20 +1,23 @@
#!/usr/bin/env python3 #!/usr/bin/env python3
# SPDX-License-Identifier: LGPL-2.1-or-later # SPDX-License-Identifier: LGPL-2.1-or-later
# pylint: disable=line-too-long,too-many-lines,too-many-branches,too-many-statements,too-many-arguments
# pylint: disable=too-many-public-methods,too-many-boolean-expressions,invalid-name,no-self-use
# pylint: disable=missing-function-docstring,missing-class-docstring,missing-module-docstring
# #
# Copyright © 2017 Michal Sekletar <msekleta@redhat.com> # Copyright © 2017 Michal Sekletar <msekleta@redhat.com>
# ATTENTION: This uses the *installed* systemd, not the one from the built # ATTENTION: This uses the *installed* systemd, not the one from the built
# source tree. # source tree.
import unittest
import time
import os import os
import tempfile
import subprocess import subprocess
import sys import sys
import tempfile
import time
import unittest
from enum import Enum from enum import Enum
class UnitFileChange(Enum): class UnitFileChange(Enum):
NO_CHANGE = 0 NO_CHANGE = 0
LINES_SWAPPED = 1 LINES_SWAPPED = 1
@ -26,59 +29,59 @@ class UnitFileChange(Enum):
class ExecutionResumeTest(unittest.TestCase): class ExecutionResumeTest(unittest.TestCase):
def setUp(self): def setUp(self):
self.unit = 'test-issue-518.service' self.unit = 'test-issue-518.service'
self.unitfile_path = '/run/systemd/system/{0}'.format(self.unit) self.unitfile_path = f'/run/systemd/system/{self.unit}'
self.output_file = tempfile.mktemp() self.output_file = tempfile.mktemp()
self.unit_files = {} self.unit_files = {}
unit_file_content = ''' unit_file_content = f'''
[Service] [Service]
Type=oneshot Type=oneshot
ExecStart=/bin/sleep 3 ExecStart=/bin/sleep 3
ExecStart=/bin/bash -c "echo foo >> {0}" ExecStart=/bin/bash -c "echo foo >> {self.output_file}"
'''.format(self.output_file) '''
self.unit_files[UnitFileChange.NO_CHANGE] = unit_file_content self.unit_files[UnitFileChange.NO_CHANGE] = unit_file_content
unit_file_content = ''' unit_file_content = f'''
[Service] [Service]
Type=oneshot Type=oneshot
ExecStart=/bin/bash -c "echo foo >> {0}" ExecStart=/bin/bash -c "echo foo >> {self.output_file}"
ExecStart=/bin/sleep 3 ExecStart=/bin/sleep 3
'''.format(self.output_file) '''
self.unit_files[UnitFileChange.LINES_SWAPPED] = unit_file_content self.unit_files[UnitFileChange.LINES_SWAPPED] = unit_file_content
unit_file_content = ''' unit_file_content = f'''
[Service] [Service]
Type=oneshot Type=oneshot
ExecStart=/bin/bash -c "echo bar >> {0}" ExecStart=/bin/bash -c "echo bar >> {self.output_file}"
ExecStart=/bin/sleep 3 ExecStart=/bin/sleep 3
ExecStart=/bin/bash -c "echo foo >> {0}" ExecStart=/bin/bash -c "echo foo >> {self.output_file}"
'''.format(self.output_file) '''
self.unit_files[UnitFileChange.COMMAND_ADDED_BEFORE] = unit_file_content self.unit_files[UnitFileChange.COMMAND_ADDED_BEFORE] = unit_file_content
unit_file_content = ''' unit_file_content = f'''
[Service] [Service]
Type=oneshot Type=oneshot
ExecStart=/bin/sleep 3 ExecStart=/bin/sleep 3
ExecStart=/bin/bash -c "echo foo >> {0}" ExecStart=/bin/bash -c "echo foo >> {self.output_file}"
ExecStart=/bin/bash -c "echo bar >> {0}" ExecStart=/bin/bash -c "echo bar >> {self.output_file}"
'''.format(self.output_file) '''
self.unit_files[UnitFileChange.COMMAND_ADDED_AFTER] = unit_file_content self.unit_files[UnitFileChange.COMMAND_ADDED_AFTER] = unit_file_content
unit_file_content = ''' unit_file_content = f'''
[Service] [Service]
Type=oneshot Type=oneshot
ExecStart=/bin/bash -c "echo baz >> {0}" ExecStart=/bin/bash -c "echo baz >> {self.output_file}"
ExecStart=/bin/sleep 3 ExecStart=/bin/sleep 3
ExecStart=/bin/bash -c "echo foo >> {0}" ExecStart=/bin/bash -c "echo foo >> {self.output_file}"
ExecStart=/bin/bash -c "echo bar >> {0}" ExecStart=/bin/bash -c "echo bar >> {self.output_file}"
'''.format(self.output_file) '''
self.unit_files[UnitFileChange.COMMAND_INTERLEAVED] = unit_file_content self.unit_files[UnitFileChange.COMMAND_INTERLEAVED] = unit_file_content
unit_file_content = ''' unit_file_content = f'''
[Service] [Service]
Type=oneshot Type=oneshot
ExecStart=/bin/bash -c "echo bar >> {0}" ExecStart=/bin/bash -c "echo bar >> {self.output_file}"
ExecStart=/bin/bash -c "echo baz >> {0}" ExecStart=/bin/bash -c "echo baz >> {self.output_file}"
'''.format(self.output_file) '''.format(self.output_file)
self.unit_files[UnitFileChange.REMOVAL] = unit_file_content self.unit_files[UnitFileChange.REMOVAL] = unit_file_content
@ -91,7 +94,7 @@ class ExecutionResumeTest(unittest.TestCase):
content = self.unit_files[unit_file_change] content = self.unit_files[unit_file_change]
with open(self.unitfile_path, 'w') as f: with open(self.unitfile_path, 'w', encoding='utf-8') as f:
f.write(content) f.write(content)
self.reload() self.reload()
@ -99,7 +102,7 @@ class ExecutionResumeTest(unittest.TestCase):
def check_output(self, expected_output): def check_output(self, expected_output):
for _ in range(15): for _ in range(15):
try: try:
with open(self.output_file, 'r') as log: with open(self.output_file, 'r', encoding='utf-8') as log:
output = log.read() output = log.read()
self.assertEqual(output, expected_output) self.assertEqual(output, expected_output)
return return
@ -108,7 +111,7 @@ class ExecutionResumeTest(unittest.TestCase):
time.sleep(1) time.sleep(1)
self.fail("Time out while waiting for the output file {} to appear".format(self.output_file)) self.fail(f'Timed out while waiting for the output file {self.output_file} to appear')
def setup_unit(self): def setup_unit(self):
self.write_unit_file(UnitFileChange.NO_CHANGE) self.write_unit_file(UnitFileChange.NO_CHANGE)
@ -124,8 +127,6 @@ class ExecutionResumeTest(unittest.TestCase):
self.check_output(expected_output) self.check_output(expected_output)
def test_swapped(self): def test_swapped(self):
expected_output = ''
self.setup_unit() self.setup_unit()
self.write_unit_file(UnitFileChange.LINES_SWAPPED) self.write_unit_file(UnitFileChange.LINES_SWAPPED)
self.reload() self.reload()
@ -168,14 +169,14 @@ class ExecutionResumeTest(unittest.TestCase):
def test_issue_6533(self): def test_issue_6533(self):
unit = "test-issue-6533.service" unit = "test-issue-6533.service"
unitfile_path = "/run/systemd/system/{}".format(unit) unitfile_path = f"/run/systemd/system/{unit}"
content = ''' content = '''
[Service] [Service]
ExecStart=/bin/sleep 5 ExecStart=/bin/sleep 5
''' '''
with open(unitfile_path, 'w') as f: with open(unitfile_path, 'w', encoding='utf-8') as f:
f.write(content) f.write(content)
self.reload() self.reload()
@ -189,7 +190,7 @@ class ExecutionResumeTest(unittest.TestCase):
ExecStart=/bin/true ExecStart=/bin/true
''' '''
with open(unitfile_path, 'w') as f: with open(unitfile_path, 'w', encoding='utf-8') as f:
f.write(content) f.write(content)
self.reload() self.reload()