1
1
mirror of https://github.com/systemd/systemd-stable.git synced 2025-02-12 21:57:27 +03:00

63131 Commits

Author SHA1 Message Date
huyubiao
a678987634 systemd-hwdb: fix unsigned and signed comparison problem
...
uint8_t c;
struct trie_node *child;

for (p = 0; (c = trie->strings->buf[node->prefix_off + p]); p++) {
        _cleanup_free_ struct trie_node *new_child = NULL;
        _cleanup_free_ char *s = NULL;
        ssize_t off;
if (c == search[i + p])
        continue;
...
When '®' is present in search, c is 194, search[i + p] is -62, c is not equal
to search[i + p], but c should be equal to search[i + p].

(cherry picked from commit b53a80966e8a2d68b66bf1b47c2ee633a71fad49)
(cherry picked from commit 3cc2aa3998aa179a726c8637dfd66a01fabb5246)
2023-09-28 14:40:43 +01:00
Lennart Poettering
b60cf1f7f4 udev: raise RLIMIT_NOFILE as high as we can
We might need a lot of fds on large systems, hence raise RLIMIT_NOFILE
to what the service manager allows us, which is quite a lot these days.

udev already sets FORK_RLIMIT_NOFILE_SAFE when forking of chilren, thus
ensuring that forked off processes get their RLIMIT_NOFILE soft limit
reset to 1K for compat with crappy old select().

Replaces: #29298
Fixes: #28583
(cherry picked from commit 1617424ce76d797d081dd6cb1082b954c4d2bf38)
(cherry picked from commit c98a24bdbdb830a5081d5ec972d62d08547d7255)
2023-09-28 14:40:43 +01:00
Mike Yuan
e13981d623 core/main: log that we assume first boot if failed to read machine-id
(cherry picked from commit 60e4b4291b0a59d77fb8d4b149d9d6672b274aed)
(cherry picked from commit c58c69ac10071f38d8d5c9b8a04f736b70fcddec)
2023-09-28 14:40:43 +01:00
Antonio Alvarez Feijoo
f274f63cdf bash-completion: add missing commands and options to systemd-dissect
(cherry picked from commit acb7d23d8f91cc0f93c82481f92d540ac45311b1)
(cherry picked from commit 6450d4e11727f0d90bcf937edf7039a667c652b8)
2023-09-28 14:40:43 +01:00
Antonio Alvarez Feijoo
64b772e127 man/systemd-dissect: various fixes
- Add synopsis to `--discover` and `--validate` options.
- `-l` is for `--list`, not for `--mtree`.

(cherry picked from commit a0582220f5fe4927487bbfd4d56d2c1abd964e4a)
(edited to remove --validate for v253, where it doesn't exist)
(cherry picked from commit 44b29d93c39d826d69734dbab88b94ad56d529b4)
2023-09-28 14:40:43 +01:00
Abderrahim Kitouni
81bb9067b9 man: fix docbook syntax for function docs
This fixes sd_bus_error_add_map and man/sd_uid_get_state

(cherry picked from commit 0ee42394374db269fc85f9cdbe5d7249fee541b3)
(cherry picked from commit 0144678b04c2193bf89e0666e7c0e9f5dce19ffa)
2023-09-28 14:40:43 +01:00
Abderrahim Kitouni
d60ae0b01a man/kernel-command-line: don't refer early_core_pattern to systemd
It is defined later in the same file

(cherry picked from commit d511acdf8257389a4b670c120717e5b6bc224986)
(cherry picked from commit b283661e01dbb5f2de166e0e25bdc01bf0dde4b1)
2023-09-28 14:40:43 +01:00
Frantisek Sumsal
bf449d79bb test: wait for the swtpm socket to appear
On slower/overloaded systems it may take a bit for the swtpm socket
to show up:

I: Started swtpm as PID 189419 with state dir /tmp/tmp.pWqUutuGUj
I: Configured emulated TPM2 device tpm-spapr
+ tee /var/tmp/systemd-test-TEST-70-TPM2_1/console.log
+ timeout --foreground 1200 /bin/qemu-system-ppc64le -smp 4 ...
qemu-system-ppc64le: -chardev socket,id=chrtpm,path=/tmp/tmp.pWqUutuGUj/sock: Failed to connect to '/tmp/tmp.pWqUutuGUj/sock': No such file or directory
E: qemu failed with exit code 1

Spotted regularly in the ppc64le cron job and in some Ubuntu CI/CentOS CI
pr runs [0].

[0] https://github.com/systemd/systemd/pull/29183#issuecomment-1721727927

(cherry picked from commit 18c3ffbfcc2d4d6d1a4680092123e510945f7a78)
(cherry picked from commit 2171f689b8596458e21ac75766326431c7d151cc)
2023-09-28 14:40:43 +01:00
Frantisek Sumsal
4dfce10b12 test: don't panic on soft lockups
We can't do anything about them anyway, and most importantly this seems
to alleviate systemd/systemd-centos-ci#660, which should make the CIs
a bit less angry (at least until the issue is addressed properly).

(cherry picked from commit 3a89904e45cbbd96fb1c5d0768de5e5fcdaaa508)
(cherry picked from commit af7d007f897818068965a6500798815cc1335b72)
2023-09-28 14:40:43 +01:00
Yu Watanabe
a5b45333a9 network/sr-iov: ignore -EINVAL in reading dev_port sysfs attribute
Fixes #27369.

(cherry picked from commit 4b12a8dd338dc640cb1965125feefdee0ac8f625)
(cherry picked from commit 149ba4f8e81fc3fbd883eed4c461a00df33e55cc)
2023-09-28 14:40:43 +01:00
Antonio Alvarez Feijoo
e730e0ce16 man/kernel-install: document missing $KERNEL_INSTALL_IMAGE_TYPE
Available since https://github.com/systemd/systemd/commit/3d5f0bfe

(cherry picked from commit cb5f21de197c7c2c291637d9234a9373d8b0aee4)
(cherry picked from commit 3e10a49d34654fd1bb6b6b87e5ce540075b535df)
2023-09-28 14:40:43 +01:00
Luca Boccassi
7844c655be boot: skip loading DTBs in type 1 when secure boot is enabled
The kernel loads the DTB from EFI before ExitBootServices():

https://github.com/torvalds/linux/blob/v6.5/drivers/firmware/efi/libstub/fdt.c#L245

DTBs can map and assign arbitrary memory ranges. The kernel refuses
to load one from the dtb= kernel command line parameter when secure
boot is enabled, as it's not safe. Let's do the same for type 1
entries, as they are unverified.

This only affects arm64 and riscv64, firmwares do not support DTB
on x86.

(cherry picked from commit 4b4d612d860a4acbbc22bc64a32637c0eb792cee)
(cherry picked from commit c1404fff32d439a726e972daa34470c863465577)
v253.11
2023-09-20 02:25:09 +01:00
Lennart Poettering
b6b50ac157 Revert "tree-wide: Mount file descriptors via /proc/<pid>/fd"
(cherry picked from commit 7b9da3861a2d27dd31c360674947005a19f3cbe7)
(cherry picked from commit d5c180b96ef389da9923985e96504901f52ac605)
v253.10
2023-09-09 01:13:18 +01:00
Yu Watanabe
971ff12380 udev: set ID_PATH properties for all pci, usb, and platform devices
Before c43ff248f94266cfc93e300a2d3d163ed805e55b, the following line in
60-drm.rules also sets ID_PATH for all pci, usb, and platform devices:
===
ACTION!="remove", SUBSYSTEM=="drm", SUBSYSTEMS=="pci|usb|platform", IMPORT{builtin}="path_id"
===
Unfortunately, some existing rules rely on the unexpected behavior.
To keep the backward compatibility, let's set ID_PATH for them.

Fixes #28411.

(cherry picked from commit 6636b2b6bf07def544dcb4faefe161d27a532692)
v253.9
2023-09-08 00:45:00 +01:00
Daan De Meyer
571ada3dcb mkosi: Re-enable arch but disable keyring checking
No need to disable arch completely, let's just disable keyring checking
to get CI working again for now.

(cherry picked from commit 16173ab1aa0e8d1032fa477178efe5957a47e5e4)
(cherry picked from commit 93bb992079fd34352d17768b743047c4f9a8248a)
2023-09-08 00:45:00 +01:00
Yu Watanabe
406b3a07cd core: allow to run generators without sandboxing on qemu-user
When running on non-native userland architecture via systemd-nspawn
and qemu-user-static QEMU-emulator, clone() with CLONE_NEWNS fails with
EINVAL.

Fixes #28901.

[zjs: add a comment in the code]

(cherry picked from commit 468018703ce1c0f123240fb6ba9b8b0b90f12930)
(cherry picked from commit 0e25a211d40d62caeb90cae92c138e9331554513)
2023-09-08 00:45:00 +01:00
Daan De Meyer
edf4a86f3d fd-util: Use /proc/pid/fd instead of /proc/self/fd
Currently, we mount via file descriptors using /proc/self/fd. This
works, but it means that in /proc/mounts and various other files,
the source of the mount will be listed as /proc/self/fd/xxx. For other
software that parses these files, /proc/self/fd/xxx doesn't mean anything,
or worse, it means the completely wrong thing, as it will refer to one of
their own file descriptors instead.

Let's improve the situation by using /proc/pid/fd instead. This allows
processes parsing /proc/mounts to do the right thing more often than not.
One scenario where even this doesn't work if when containers are involved,
as with the pid namespace unshared, even /proc/pid/fd will mean the wrong
thing, but it's no worse than /proc/self/fd which will always means the wrong
thing.

This also doesn't work if we mount via file descriptor and then exit, as the pid will
be gone, but it does work as long as the process that did the mount is alive, which
makes it useful for systemd-dissect --with for example if the program we run in the
image wants to parse /proc/mounts.

(cherry picked from commit 4419735822d72744dad1c76a57463561b332897a)
(cherry picked from commit 8046167dc2d6d7ad62a447991efcd0404d784180)
2023-09-08 00:45:00 +01:00
Daan De Meyer
299e6cd33b tree-wide: Always include <net/if.h> before related linux headers
Otherwise, we get redefinition errors if <net/if.h> is included later
on by another header.

(cherry picked from commit 2af02e61657aa513aa7b6df7fd1a04b13f853cef)
(cherry picked from commit 49a3ecd71d700dc2d914bfee70dd93275b698ae7)
2023-09-08 00:45:00 +01:00
Daan De Meyer
3621e136ad debug-generator: Use generator_add_symlink()
(cherry picked from commit bd6c95c00b7a25b4d360bac22d3a3bc54132c415)
(cherry picked from commit 0d1198a79c721dd35a66588ad72d446ce4fa15f0)
2023-09-08 00:45:00 +01:00
Luca Boccassi
f3406de821 dissect: add 'f2fs' to allow-listed filesystems
f2fs is actively maintained upstream, and popular in certain device
categories (phones, embedded), so allow-list by default.

Fixes https://github.com/systemd/systemd/issues/29026

(cherry picked from commit ee6cf8eaf1770d9a32e6f80bb9d37b64c838e230)
(cherry picked from commit f38b883b030031a79205f0d559906e18567706df)
2023-09-08 00:45:00 +01:00
Lennart Poettering
98584e89ad logind: give better error messages when failing to attach devices to seats
When the user tries to attach a device lacking ID_FOR_SEAT they
currently get a very cryptic error message. Let's improve the situation
a bit. Still a bit cryptic maybe, but much less so.

Inspired-by: https://lists.freedesktop.org/archives/systemd-devel/2023-September/049469.html
Inspired-by: https://lists.freedesktop.org/archives/systemd-devel/2023-September/049484.html
Also-see: https://lists.freedesktop.org/archives/systemd-devel/2023-September/049470.html
Also-see: https://lists.freedesktop.org/archives/systemd-devel/2023-September/049489.html
(cherry picked from commit 08237f062e9a2020c6d457a4112e363ee9ff879d)
(cherry picked from commit 3126a5a5aa7b9b242c247e1595b60ac244ee2241)
2023-09-08 00:45:00 +01:00
Yu Watanabe
262ba9bba6 icmp6-util: make icmp6_receive() accept the null source address
Fixes #29050.

(cherry picked from commit 4961f5664647ee32fe9f2c8981cdd7852e511a09)
(cherry picked from commit fabdb2832da1fc380c76473161119531c97843e5)
2023-09-08 00:45:00 +01:00
Yu Watanabe
bd96e3ace7 icmp6-util: several cleanups for icmp6_receive()
- Rename the argument for storing the sender address,
- allow to call it with NULL for ret_xyz,
- reduce needless copy of timestamp when the message does not have
  timestamp.

(cherry picked from commit 512116383215c2f61172dd20e45871ff5d16c030)
(cherry picked from commit 811edcef2d7593b45bc8e683e50a580763ebf447)
2023-09-08 00:45:00 +01:00
Yu Watanabe
9f545c1aea sd-ndisc,sd-radv: fix use of uninitialized value
When icmp6_receive() fails, then the source address is not initialized yet.

(cherry picked from commit 4674f407b2a96baaed4c8226342bccb313463717)
(cherry picked from commit 9dec95c8c50dc0057454363affe02b9114d14055)
2023-09-08 00:45:00 +01:00
Frantisek Sumsal
98cae25cbb shell-completions: add missing systemctl verbs/options
Resolves: #29048
(cherry picked from commit 97e2785292d6c9ff35887126876f631f6d23b23c)
(cherry picked from commit ae5445a059aca81f4f39eecd2268390e0f9937f9)
2023-09-08 00:45:00 +01:00
Frantisek Sumsal
2cf4bbd373 shell-completions: code cleanup
(cherry picked from commit 05ebcbd5c54ffaa59ce6855b8cb9907ee4e43a86)
(cherry picked from commit 307a5e8ef41ccf67c324213bdc768673edc59fd8)
2023-09-08 00:45:00 +01:00
Christian Hergert
6a163f1557 oomd: avoid unnecessary wake-ups for ManagedOOMSwap
If there are no "ManagedOOMSwap" entries to monitor, then the event source
can be completely disabled. This scenario appears to be common and avoiding
the wake-ups can save idle energy consumption.

This was discovered while using Sysprof for various GNOME 45 performance
tuning. systemd-oomd goes from waking up a few times a second to no
wake-ups helping keep a laptop in deep(er) sleep.

Signed-off-by: Christian Hergert <chergert@redhat.com>
(cherry picked from commit b63beb4d283438be2b0f5c62757ab0db7dee8d65)
(cherry picked from commit 08d0b94e363cba14c8176bc2279070dcea020fd4)
2023-09-08 00:45:00 +01:00
msizanoen
b10bc73918 sd-login: Fix sd_pidfd_* function signature parameter types
The type of a file descriptor is `int`, not `pid_t`. This should not
have any effects on API consumers as `pid_t` is already typedef'd as
`int` on all glibc-based systems.

(cherry picked from commit 904b8bb5a8da4aa0257f7730e4fbaa7ba7c67742)
(cherry picked from commit 6f83ab7d70f0e6f2023bc07f0a0a02ea2e8257b5)
2023-09-08 00:45:00 +01:00
msizanoen
c70dc59688 login: Properly handle -EIO in session_leave_vt
session_leave_vt may be called after the VT device was hung up, which
will cause vt_release to fail with -EIO. This is known to cause an issue
with GNOME 44 on Fedora where gdm-session-worker sometimes freezes when
trying to switch to VT 1 after a `loginctl terminate-user` operation.

Fix this by reopening the VT in session_leave_vt if we get an -EIO.

(cherry picked from commit 99d4ad71b72045d6352ba221105843fc6b600717)
(cherry picked from commit 1bfe066deb43792f6e5d33ce6d2e92b7a42c4e23)
2023-09-08 00:45:00 +01:00
Chris Patterson
e94ddb830b 99-systemd.rules.in: tag PTP devices with systemd
Chronyd and similar time services, when using PTP devices, may need
the BindsTo/After directives to ensure the devices are available
before starting.  Tag PTP devices with systemd to allow for wider
adoption.

Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
(cherry picked from commit 23cbe90d7db6b569ae2fc18ad88f99f8ef505593)
(cherry picked from commit e3a69bdbc03c90864cc39116e45e149fa37de2f4)
2023-09-08 00:45:00 +01:00
Michael Vasseur
1ab8d21988 pkg.m4 macro needs brackets
See documentation at: https://manpages.debian.org/testing/pkgconf/pkg.m4.7.en.html

Without this the macro was not always correctly resolved so the correct command was not used in the rest of the snippet.

(cherry picked from commit c91d636fadc07169641e8a96a2c60083a15e0f77)
(cherry picked from commit 01841ae82935bdd4f8b01af800f5c53c0fb2adbe)
2023-09-08 00:45:00 +01:00
Zbigniew Jędrzejewski-Szmek
41a3e30b12 man/gpt-auto-generator: avoid saying "negative" for boolean
Fixes #28928.

(cherry picked from commit 7abb0eef8fe4510e04c365778489af01ad562587)
(cherry picked from commit 9d43d9e8c54933ffda8b9b31948c597ff8fee9de)
2023-09-08 00:45:00 +01:00
Daan De Meyer
30ce78cb1a Limit rlim_max in rlimit_nofile_safe() to nr_open
We might inherit a max rlim value that's larger than the kernel's
maximum (nr_open). This will cause setrlimit() to fail as the given
maximum is larger than the kernel's maximum. To get around this,
let's limit the max rlim we pass to rlimit() to the value of nr_open.

Should fix #28965

(cherry picked from commit f470dafddcd688c3ea6031d4bbcbf934fd094711)
(cherry picked from commit a980b83fe07521e4654d68331c31db3a4459412c)
2023-09-08 00:45:00 +01:00
Lennart Poettering
b94677ee3d boot: explain why we refuse to edit kernel cmdline when we do so
(cherry picked from commit c4d281fa1a6a99208daef2b80f57bcad37a6eaab)
(cherry picked from commit 5f09b13339d522e629dbb1d8fd29264cd939c278)
2023-09-08 00:45:00 +01:00
Lennart Poettering
4e51e336c8 man: mention two more things logind does
Prompted by: #28902

(cherry picked from commit 1126841553a28f22eb6bc55eeed8af8d98610f71)
(cherry picked from commit bec4bb92e24fd284974a2d9e4e67563da2732cbb)
2023-09-08 00:45:00 +01:00
Daan De Meyer
d651df3ab8 install: Drop install_info_may_process() from unit_file_get_default()
This currently makes unit_file_get_default() fail if the default
target is transient which shouldn't make us fail to get the default
unit.

(cherry picked from commit 3c1c52f2c9e67fe60b36325be7292ff0baaf808b)
(cherry picked from commit a6bd20e3de03109c81134838f9da587570af3cae)
2023-09-08 00:45:00 +01:00
Daan De Meyer
d8cd17d109 parse-helpers: Add PATH_KEEP_TRAILING_SLASH
(cherry picked from commit ce60b3a40a89bb5d116003343c56c55a0da9f8fb)
(cherry picked from commit 979b2abbdde5ba5e985eca343e67ebadd2a7c220)
2023-09-08 00:45:00 +01:00
Daan De Meyer
c1b5f5b081 path-util: Add path_simplify_full()
Sometimes its useful to keep a trailing slash in the path so let's
add path_simplify_full() and a flag to do just that.

(cherry picked from commit 4541d045b2cc2834add853f06293d4474ac403e4)
(cherry picked from commit ff45789ea3323d2c2526ed76d06a0f7625d778df)
2023-09-08 00:45:00 +01:00
Yu Watanabe
6d25022e36 core/mount: disable timer event source when USEC_INFINITY
Setting USEC_INFINITY to timer event source should not cause any
problem. But, disabling timer event source should be preferable.

[zjs: simplify the call to sd_event_source_set_enabled()]

(cherry picked from commit 57d2b6a96f997c23bed37d74c6da087fb06081d2)
(cherry picked from commit 6b1346f1f01fbe384a7c828db4d7dee4921e483c)
2023-09-08 00:45:00 +01:00
Daan De Meyer
6691b54958 hostname: Make sure we pass error to bus_verify_polkit_async()
Fixes #28943

(cherry picked from commit b56ee692334231f0312c2fd142b9f2a84da14ac9)
(cherry picked from commit d38ba62059c7d28dbd259699df224ec19a10f4aa)
2023-09-08 00:45:00 +01:00
Zbigniew Jędrzejewski-Szmek
33d1a10c6d manager: fix error handling after failure to set up child
exec_child() is supposed to set *exit_status when returning failure.
Unfortunately, we didn't do that in two cases. The result would be:
- a bogus error message "Failed at step SUCCESS spawning foo: …",
- a bogus success exit status.

Bugs introduced in 390902012c5177b6b01bc634b2e9c704073d9e7d and
ad21e542b20f0fb292d1958d3a759bf3403522c2.

The code is reworked to add some asserts and not set exit_status in the caller
so that it's clearer (also to the compiler) that it needs to be set.

(cherry picked from commit 5fa01ac0369f0f225ab1e1f90f6b7058cc4deaaf)
(cherry picked from commit 063d67fe3255128da75d0e8ccd5afeb5c07699ff)
2023-09-08 00:45:00 +01:00
Warren
c03d5f1ddb p11kit: check the flags associated with the slot instead of flags associated with the token
The logic around checking PKCS11 tokens (used by systemd-cryptenroll) contains a bug.
The code is checking the flags field of a pkcs11 token_info structure against a set of flags defined for the pkcs11 slot_info structure. This PR changes the check so that the correct structure's flag field is being checked.
(Reference to the PKCS#11 spec:http://docs.oasis-open.org/pkcs11/pkcs11-base/v2.40/os/pkcs11-base-v2.40-os.html, section CK_SLOT_INFO).

(cherry picked from commit 5007942477ecfb69702f542cb6770ea4b5bc1e57)
(cherry picked from commit 117fa69b71a8e39f663135c88f78a2412d87c4df)
2023-09-08 00:45:00 +01:00
Mike Yuan
1a77552257 sleep: clear EFI HibernateLocation if writing kernel config fails
Follow-up for f1f331a252d22c15f37d03524cce967664358c5c

(cherry picked from commit 031a399d87de5a47d395bb12b70e112c83b02c3f)
(cherry picked from commit f2fad1523986d9385a670a51f0332031dfe2f07e)
2023-09-08 00:45:00 +01:00
Rahil Bhimjiani
ef7eedb8c0 man: kernel-install(8) add uki.conf in FILES & add ukify(1) in SEE ALSO
Signed-off-by: Rahil Bhimjiani <rahil3108@gmail.com>
(cherry picked from commit f5263dd09e428df42c3d3b12f7e8ca95121ef3ee)
(cherry picked from commit 0baa4866d5f4b68d5d432ae88ddd73282bafcb07)
2023-09-08 00:45:00 +01:00
Michael A Cassaniti
b923225dec file-io: Fix copying sparse files
This change makes sure a data copy using copy_bytes() does not exceed the
max_bytes value when using COPY_HOLES and max_bytes stops before the next
data section.

(cherry picked from commit c2dfcbd48e780e49bfc11f1c34077f6c98891e40)
(cherry picked from commit 7bfe3c6215b03973016aa0931b16628253d7b985)
2023-09-08 00:45:00 +01:00
Franck Bui
c0a45a591c test-mountpoint-util: /root might be mounted
On openSUSE with BTRFS, /root has to be mounted as dedicated subvolume to avoid
restoring it when a rollback of the system happens.

(cherry picked from commit 487ae08b85048f86e72e86d6c601d4c558b6cb8a)
(cherry picked from commit 5c3fa0cfeea1907d2d71bb6dfadc94f661ce3e40)
2023-09-08 00:45:00 +01:00
Lennart Poettering
3a25191361 coredump: fix error path
We must go through finish, to undo the destruction of the final elements
of the iovw properly.

(cherry picked from commit 946dc7c635f050129896d1515c08a81504af2421)
(cherry picked from commit 10304c278755823605655b21c8dbb96f2b58b7e6)
2023-09-08 00:45:00 +01:00
Lennart Poettering
495f887e55 coredump: explicitly document that in order to process a coredump we have to write it to disk first
Prompted by: #28740

(cherry picked from commit 85ec1b6efadf3466bd1d265950f3d967a43cb1d0)
(cherry picked from commit a5d9940957bf7a3a90a9fc41b6a4d76cfe85aa59)
2023-09-08 00:45:00 +01:00
Lennart Poettering
bdc79b27ee man: let's tone down the recommendation to use Type=exec a bit
This is a follow-up for #28596.

I think the suggestion to use Type=exec uses too strong wording:
Type=exec has non-trivial drawbacks over Type=simple, and they deserve
to be mentioned.

Hence drop the <emphasis> and turn this around so that Type=exec is
*recommended*, but Type=simple is not expressly discouraged, because
there are plenty reasons to use it.

Add a brief discussion where Type=simple might be preferable.

Also, fix the outright unruth that Type=exec was the "simplest and
fastest", because it certainly is a lot, but not that.

(cherry picked from commit e5e900edcd3b245499379201072cbb69346e9798)
(cherry picked from commit 045ff3b47a2f6611e079cfdaf330366239b38c98)
2023-09-08 00:45:00 +01:00
Daan De Meyer
8a5b93fbe6 tree-wide: Fix -Wmaybe-uninitialized compilation warnings
(cherry picked from commit 7e48f3ba71614604e2b7fbb5bcfdb1c848600e89)
(cherry picked from commit 550cd149c1ffd7e8b7ce85d30fbcdb8a8b5ce394)
2023-09-08 00:45:00 +01:00