Yu Watanabe
804775577d
sd-radv: update how to calculate interval of sending advertisements
2021-10-27 19:27:23 +09:00
Yu Watanabe
0945767012
sd-radv: router lifetime must be 0 or between 4 seconds and 9000 seconds
...
See RFC 4861 section 6.2.1.
2021-10-27 19:27:07 +09:00
Yu Watanabe
72db0a714b
sd-radv: introduce RADV_DEFAULT_ROUTER_LIFETIME_USEC
2021-10-27 19:05:55 +09:00
Yu Watanabe
e786c2e50f
sd-radv: add several notes about constants
2021-10-27 19:03:58 +09:00
Yu Watanabe
03ec10fdf4
sd-radv: make several constants not exposed
2021-10-27 19:03:35 +09:00
Yu Watanabe
d6fc0d674f
sd-radv: drop SD_ prefix for unexposed constants
2021-10-27 19:03:31 +09:00
Yu Watanabe
7003b11487
sd-radv: make sd_radv_set_router_lifetime() take usec_t (uint64_t)
2021-10-27 16:13:09 +09:00
Yu Watanabe
a84171ce6f
libsystemd-network: do not warn when log_dhcp_client() or friends with NULL
2021-10-26 08:09:40 +09:00
Yu Watanabe
113e124f9b
icmp6: shorten code a bit
2021-10-21 22:40:03 +09:00
Yu Watanabe
ea51deb188
dhcp: shorten BPF code a bit
...
- replace `A = k` and `X = A` with `X = k`,
- replace `A ^= X` and `A == 0` with `A == X`.
- use UINT32_MAX when accept a packet
2021-10-21 22:39:53 +09:00
Yu Watanabe
155943b259
dhcp: rebreak function arguments
2021-10-21 22:39:43 +09:00
Yu Watanabe
b8319d748f
dhcp: fix assertions
2021-10-21 22:39:43 +09:00
Yu Watanabe
d70c78131d
dhcp: shorten code a bit
2021-10-21 22:39:43 +09:00
Yu Watanabe
36f1955da8
lldp: shorten code a bit
2021-10-21 22:39:43 +09:00
Yu Watanabe
e2c7c38b74
arp-util: shorten BPF code a bit
...
- replace `A = k` and `X = A` with `X = k`,
- replace `A ^= X` and `A == 0` with `A == X`.
- use UINT32_MAX when accept a packet
2021-10-21 22:39:25 +09:00
Yu Watanabe
653ddc1d18
sd-dhcp6-client: introduce sd_dhcp6_lease_get_timestamp()
2021-10-20 02:36:20 +09:00
Yu Watanabe
7502812c92
sd-dhcp6-client: max_retransmit_time must be positive
...
Found by LGTM.com analysis.
2021-10-13 02:49:49 +09:00
Yu Watanabe
fea8c18085
sd-dhcp6-client: introduce dhcp6_option_can_request()
2021-10-13 02:49:49 +09:00
Yu Watanabe
f5e3619b70
sd-dhcp6-client: add missing options
2021-10-12 20:48:19 +09:00
Yu Watanabe
ac94edc857
sd-dhcp6-client: add missing parenthesis
2021-10-12 20:48:19 +09:00
Yu Watanabe
59f1ded834
sd-dhcp6-client: add missing message types
...
This also changes the prefix: DHCP6_ -> DHCP6_MESSAGE_.
2021-10-12 20:48:19 +09:00
Yu Watanabe
b261b5f416
sd-dhcp6-client: name one more enum
2021-10-12 20:48:19 +09:00
Yu Watanabe
dd5e9378a2
sd-dhcp6-client: typedef several enums
...
Also introduces _MAX and _INVALID for several enums.
2021-10-12 20:48:19 +09:00
Zbigniew Jędrzejewski-Szmek
78ae9d3100
Merge pull request #20853 from yuwata/network-radv-set-default-timeouts
...
network: RADV: set default timeouts
2021-10-12 10:49:03 +02:00
Yu Watanabe
f21b863eeb
test: use assert_se() instead of assert()
2021-10-12 15:20:28 +09:00
Yu Watanabe
7ebb14313f
sd-radv: rename sd_radv_prefix_set_route_prefix() -> sd_radv_route_prefix_set_prefix()
2021-10-12 03:10:30 +09:00
Lennart Poettering
7fbae5b706
tree-wide: use C99 __func__ rather than obsolete __FUNCTION__
...
We use __func__ almost everywhere, but there are some holdouts. Fix
that.
2021-10-11 14:10:39 +02:00
Lennart Poettering
fe92eb795b
network: use official bswap_32() rather than inofficial __bswap_32()
...
The former is a macro for the latter, but let's use the official API
(the one that has an API).
2021-10-11 14:10:07 +02:00
Yu Watanabe
e210f027e0
sd-dhcp6-client: rename dhcp6_lease_set_dns() -> dhcp6_lease_add_dns()
...
As it is allowed that multiple DNS server options appear in the message.
2021-09-29 15:29:41 +09:00
Yu Watanabe
e693e96961
sd-dhcp6-client: do not merge NTP and SNTP options
...
Previously, SNTP option is ignored when it appears after NTP option(s),
but merged later NTP options when it appears first.
This makes split the NTP and SNTP addresses, and use SNTP addresses only
when no NTP option is provided.
2021-09-29 15:29:41 +09:00
Yu Watanabe
9c3d46bf8d
sd-dhcp6-client: support multiple NTP server options
...
Also, it is allowed that the suboption appears multiple times, and each
suboption contains one NTP server.
2021-09-29 15:29:41 +09:00
Yu Watanabe
41b14f0329
sd-dhcp6-client: support multiple domains
2021-09-29 15:29:41 +09:00
Yu Watanabe
5cf67bb407
sd-dhcp6-client: make dhcp6_lease_free() accepts NULL
2021-09-29 15:29:40 +09:00
Yu Watanabe
edeee50b3d
sd-dhcp6-client: drop domains_count and ntp_fqdn_count
2021-09-29 15:29:40 +09:00
Yu Watanabe
548c33d712
sd-dhcp6-client: use dhcp6_option_parse() in client_parse_message()
2021-09-29 15:29:40 +09:00
Yu Watanabe
3f8227bf83
sd-dhcp6-client: constify several arguments
2021-09-29 15:29:40 +09:00
Yu Watanabe
b27dcf0813
sd-dhcp6-client: slightly modernize dhcp6_option_parse_domainname()/domainname_list()
2021-09-29 15:29:40 +09:00
Yu Watanabe
ad3c84204c
sd-dhcp6-client: fix buffer size calculation in dhcp6_option_parse_ip6addrs()
...
GREEDY_REALLOC() takes number of elements, not buffer size.
This also rename dhcp6_option_parse_ip6addrs() to
dhcp6_option_parse_addresses().
2021-09-29 15:29:40 +09:00
Yu Watanabe
8a8955507a
sd-dhcp6-client: modernize dhcp6_option_parse_ia()
...
This makes
- the function not update the arguments for storing results on error,
- use dhcp6_option_parse() to parse sub options,
- ignore all errors, except for -ENOMEM, in parsing sub options,
- update log messages.
2021-09-29 15:29:40 +09:00
Yu Watanabe
4af39cb8ec
sd-dhcp6-client: make dhcp6_option_parse_status() also parse error message
...
This also introduce dhcp6_option_parse_ia_options(). Currently, it is
assumed that each IA address or PD prefix may contain a status sub-option.
But it is not prohibited that other sub-options or multiple status
options are contained.
2021-09-29 15:29:36 +09:00
Yu Watanabe
e620104956
test: add tests for reading unaligned data
2021-09-29 15:18:59 +09:00
Yu Watanabe
b89a3758e9
sd-dhcp6-client: modernize dhcp6_option_parse()
...
- merge dhcp6_option_parse() with option_parse_hdr().
- do not assign/update any values on error.
- use assert() instead of assert_return(), as the assertions cannot
be triggered by a library user.
2021-09-29 15:18:59 +09:00
Yu Watanabe
dc95e21d33
sd-dhcp6-client: constify one argument
2021-09-29 15:18:59 +09:00
Yu Watanabe
5977b71f28
libsystemd-network: make sd_dhcp_client_get_ifname() or friends return negative errno on error
2021-09-29 03:37:09 +09:00
Yu Watanabe
01afd0f7f5
tree-wide: make format_ifname() or friends return negative errno on failure
...
Also,
- drop unnecessary +1 from buffer size, as IF_NAMESIZE or IFNAMSIZ
includes the nul at the end.
- format_ifname() does not update buffer on failure,
- introduces format_ifname_alloc(), FORMAT_IFNAME(), and their friends.
2021-09-29 03:37:06 +09:00
Yu Watanabe
35777f5178
sd-lldp-rx: make lldp_rx_free() and lldp_neighbor_free() accept NULL
2021-09-28 17:55:19 +09:00
Yu Watanabe
92466b8da2
sd-lldp-rx: sd_event should be attached when lldp_rx_start_timer() is called
2021-09-28 17:55:19 +09:00
Yu Watanabe
3e4a202519
sd-lldp-rx: do not enable timer event source in sd_lldp_rx_get_neighbors()
...
It must be just a simple getter.
2021-09-28 17:55:19 +09:00
Yu Watanabe
0cd7e072b4
sd-lldp-rx: use _cleanup_ attribute at one more place
2021-09-28 17:55:19 +09:00
Yu Watanabe
71c4f7e895
sd-lldp-rx: wrap long line
2021-09-28 17:55:19 +09:00