Lennart Poettering
2dc66a6417
test: modernize test-alloc-util.c test a bit
2019-07-12 09:11:44 +02:00
Lennart Poettering
7d025debfa
alloc-util: drop _alloc_(2, 3) decorator from memdup_suffix0_multiply()
...
This decorator tells compilers that the memory we return is shorter than
it actually is, thus triggering misleading bad memory access complaints.
Fixes : #13026
2019-07-12 09:11:40 +02:00
Lennart Poettering
27dd6e1b12
Merge pull request #13022 from keszybz/coverity-cleanups
...
Coverity cleanups
2019-07-12 07:37:44 +02:00
Yu Watanabe
a04285c6b1
Merge pull request #13031 from yuwata/network-route-type-local-12975-2
...
network: make Route.Type= support local or friends
2019-07-12 14:31:50 +09:00
Lennart Poettering
b910cc72c0
tree-wide: get rid of strappend()
...
It's a special case of strjoin(), so no need to keep both. In particular
as typing strjoin() is even shoert than strappend().
2019-07-12 14:31:12 +09:00
Yu Watanabe
6d60f9dbe6
test-network: add tests for route with type local, multicast, anycast, or broadcast
2019-07-12 09:39:43 +09:00
Yu Watanabe
d3e291fd62
network: also show route protocol in debugging logs
2019-07-12 09:39:43 +09:00
Yu Watanabe
1b64651bd1
network: use string table for route protocol
2019-07-12 09:39:43 +09:00
Yu Watanabe
41b90a1eb5
network: use string table to parse route table or scope
2019-07-12 09:39:43 +09:00
Yu Watanabe
b297e0a7b0
network: show route scope, table, and type in debugging logs
2019-07-12 09:39:43 +09:00
Yu Watanabe
39f26098c9
network: update log message
...
Follow-up for 7f474ed78d
and
44e891bbf6
.
2019-07-12 09:39:43 +09:00
Yu Watanabe
94d6e29963
network: make Route.Type= support local, broadcast, anycast, multicast, nat, and xresolve
...
Closes #12975 .
2019-07-12 09:39:43 +09:00
Yu Watanabe
7a22312d68
network: use string table to parse route type
2019-07-12 09:39:43 +09:00
Yu Watanabe
5424fd9573
test-network: test more bridge properties
...
Imported from networkd-test.py
2019-07-12 09:39:43 +09:00
Yu Watanabe
6fa0524133
Merge pull request #12971 from yuwata/network-reassign-static-routes
...
network: reassign static routes and process reply address messages
2019-07-12 09:36:16 +09:00
Yu Watanabe
8bf7e6709b
Merge pull request #13024 from poettering/errno-or-else
...
Errno or else
2019-07-12 09:33:21 +09:00
Zbigniew Jędrzejewski-Szmek
8e9d1eece6
shared/ask-password-api: backspace all chars at once
...
We'd call loop_write() separately for each char. Let's be nice to
serial console users, and write the full string in one go.
Coverity was complaining that we're not checking the return value
from loop_write(). Rework the code a bit and add voidify.
CID#1402323.
2019-07-12 00:35:05 +02:00
Zbigniew Jędrzejewski-Szmek
b86a91e7ba
test-process-util: invert reporting to make sure that we're not dividing by 0
...
CID#1402334.
2019-07-12 00:34:48 +02:00
Zbigniew Jędrzejewski-Szmek
0584b17a8c
udevd: add helper with error handling to synthesize "change" events
...
Coverity was unhappy that we ignore the return value from write_string_file().
We should at least warn. CID#1302373.
2019-07-12 00:17:47 +02:00
Zbigniew Jędrzejewski-Szmek
2aa07538ba
test: minor modernization
...
Coverity was complaining that read() does not terminate the data. But
we did that termination earlier, so covirity is wrong (CID#1402306, CID#1402340).
Let's modernize the style a bit nevertheless.
(size_t) cast is needed to avoid the warning about comparison, iff
the value is not a constant.
2019-07-12 00:17:45 +02:00
Lennart Poettering
66855de739
tree-wide: make use of errno_or_else() everywhere
2019-07-11 23:20:31 +02:00
Lennart Poettering
fed813778f
errno-util: add new errno_or_else() helper
2019-07-11 23:20:31 +02:00
Frantisek Sumsal
4747b645c6
Merge pull request #13025 from poettering/tmpfiles-fixo
...
unbreak the build
2019-07-11 19:55:55 +00:00
Lennart Poettering
be9d8212a5
Merge pull request #13017 from yuwata/network-neighbor-lladdr-13015
...
network: rename Neighbor.MACAddress= and also support IPv4 address
2019-07-11 19:23:29 +02:00
Lennart Poettering
a345cf448d
tmpfiles: use path_join() where it makes sense
2019-07-11 18:42:26 +02:00
Lennart Poettering
d34cd5711d
tmpfiles: fix build
...
After I merged #12750 we don't build anymore, since the merged PR (which
passed CI) uses prefix_root() which doesn't exist anymore. Let's fix
that.
2019-07-11 18:41:14 +02:00
Evgeny Vereshchagin
0772b11cc8
tests: turn on the "object-size" UBSan check on Fuzzit
...
Now that 2eb1c19881
is merged it should be safe.
2019-07-11 19:37:22 +03:00
Lennart Poettering
6c75f78e94
Merge pull request #12750 from keszybz/tmpfiles-c-copy
...
Make tmpfiles C use --root
2019-07-11 18:13:19 +02:00
Yu Watanabe
7a555216df
udevadm: ensure 'udevadm info -w' show updated result
...
This seems not necessary, but just for safety.
2019-07-11 17:39:36 +02:00
Lennart Poettering
2e8e1a1ab6
Merge pull request #12461 from Werkov/fix-job-ordering
...
Refactor job ordering implementation (and fix cycle detection)
2019-07-11 16:43:58 +02:00
Yu Watanabe
c1b01a62d1
test-network: add test for route reassignment
2019-07-11 22:37:58 +09:00
Yu Watanabe
6545067aa9
network: re-assign static routes when dynamic address is updated
...
Follow-up for b5799eeb07
.
Closes #7354 .
2019-07-11 22:37:00 +09:00
Yu Watanabe
73854ba1a0
network: process address reply message
2019-07-11 22:37:00 +09:00
Yu Watanabe
7ed5420ab2
network: rework route_scope_from_address()
2019-07-11 22:37:00 +09:00
Yu Watanabe
9a897e22d4
util: introduce in4_addr_equal()
2019-07-11 22:37:00 +09:00
Yu Watanabe
661113a2a2
network: route_configure() do nothing when it returns 0
2019-07-11 22:37:00 +09:00
Yu Watanabe
74761cf37e
test-network: add testcase that Neighbor.LinkLayerAddress= is IP address
2019-07-11 22:22:29 +09:00
Yu Watanabe
d86f5c194c
test-network: use Neighbor.LinkLayerAddress= instead of deprecated Neighbor.MACAddress=
2019-07-11 22:22:29 +09:00
Yu Watanabe
f5bab0d9c0
network: fdb: use ether_addr_from_string()
2019-07-11 22:22:29 +09:00
Yu Watanabe
8f8404d4c8
network: fdb: do not allocate separated memory for lladdr
2019-07-11 22:22:29 +09:00
Yu Watanabe
044d4b4067
network: drop invalid [Neighbor] section earlier
2019-07-11 22:22:29 +09:00
Yu Watanabe
b956364db0
network: rename Neighbor.MACAddress= to Neighbor.LinkLayerAddress=
...
And make it support IPv4 address.
Closes #13015 .
2019-07-11 22:22:29 +09:00
Yu Watanabe
49808e0e2d
network: NDA_LLADDR attribute can also take struct in_addr
2019-07-11 22:22:29 +09:00
Yu Watanabe
5dc3dbe855
sd-netlink: make sd_netlink_message_read() returns size of read data
2019-07-11 22:22:29 +09:00
Lennart Poettering
10859c4902
Merge pull request #12176 from poettering/clean-dir2
...
add "systemctl clean" operation for clearing out StateDirectory=, CacheDirectory=, … of a service unit
2019-07-11 15:12:02 +02:00
Lennart Poettering
2eb1c19881
json: always allocate at least sizeof(JsonVariant) bytes
...
ubsan apparently doesn't like us being too smart here. Given the
difference is just a few bytes, let's avoid the noise.
Fixes : #13020
2019-07-11 15:10:33 +02:00
Lennart Poettering
caa19815ea
update TODO
2019-07-11 12:18:51 +02:00
Lennart Poettering
8c8208cb80
man: document new "systemctl clean…" operation
2019-07-11 12:18:51 +02:00
Lennart Poettering
273fe5d3cb
test: add testcase for new CleanUnit logic
2019-07-11 12:18:51 +02:00
Lennart Poettering
a7056cde56
systemctl: port "systemctl start --wait" logic to new bus-wait-for-units.c API
2019-07-11 12:18:51 +02:00