1
1
mirror of https://github.com/systemd/systemd-stable.git synced 2024-12-23 17:34:00 +03:00
Commit Graph

28817 Commits

Author SHA1 Message Date
Tobias Stoeckmann
6f94e420e8 journal: prevent integer overflow while validating header (#5569)
It is possible to overflow uint64_t while validating the header of
a journal file. To prevent this, the addition itself is checked to
be within the limits of UINT64_MAX first.

To keep this readable, I have introduced two stack variables which
hold the converted values during validation.
2017-03-13 08:14:42 +01:00
Martin Pitt
0e7d368263 Merge pull request #5571 from keszybz/tarball-generation-tweaks
Tarball generation tweaks
2017-03-13 08:12:45 +01:00
Zbigniew Jędrzejewski-Szmek
1070d271fa headers: check that __INCLUDE_LEVEL__ is defined before using it (#5575)
That macro is a gcc extension, and while widely supported, not ubiquitous.
In particular the coverity scanner is having trouble with it.
2017-03-13 08:11:24 +01:00
Zbigniew Jędrzejewski-Szmek
962a18980d README: include small graphs of open issues and pull requests (#5576) 2017-03-13 08:10:04 +01:00
Yu Watanabe
44ccb3d723 resolve: add missing space in output message (#5574) 2017-03-12 20:12:03 -04:00
Zbigniew Jędrzejewski-Szmek
1e7a425100 build-sys: add helper command to sign tarballs 2017-03-11 19:17:38 -05:00
Zbigniew Jędrzejewski-Szmek
92f58d6647 build-sys: simplify git tar invocation
git is nowadays nice enough to compress based on the output file suffix,
let's make use of that.
2017-03-11 19:09:27 -05:00
Zbigniew Jędrzejewski-Szmek
d5e15d2fd7 build-sys: make more targets .PHONY 2017-03-11 19:01:43 -05:00
Michal Sekletar
8feabc4626 Fix typo in function name (#5565) 2017-03-10 09:16:24 -05:00
Bastien Nocera
e17efdfac2 hwdb: Add new quirk type to documentation
Missed in b698b5c.
2017-03-09 16:40:25 +01:00
Zbigniew Jędrzejewski-Szmek
e5b5118d28 Merge pull request #5560 from hadess/keyboard-leds
hwdb: Add property for keyboards without LEDs
2017-03-09 10:30:40 -05:00
Bastien Nocera
b698b5cf85 hwdb: Add property for keyboards without LEDs
It is useful for desktop environments to be able to show Caps-Lock or
Num-Lock status changes as an on-screen display when using a keyboard
that doesn't have LEDs for this.

Closes: #5559
2017-03-09 14:53:52 +01:00
Bastien Nocera
6a36cfec4a hwdb: Better documentation for keyboard quirks
Split up the device matching explanation, and add documentation for
the fixed layout quirk.
2017-03-09 14:47:53 +01:00
Martin Pitt
37377227ff build-sys: only install legacy *.pkla files with old polkit versions (#5555)
The legacy *.pkla files are not required when running against polkit ≥ 106,
and we want to avoid shipping files in /var if possible (but pkla files
can only be in /etc/ or /var).

Only install the *.pkla files if we detect an old polkit version during
configure. Don't install them if polkit isn't installed during build, as
distributions other than Debian-based ones have moved to the new polkit
long ago.

Fixes #5523
2017-03-08 08:20:11 -05:00
Torstein Husebø
6cf5a96489 man: fix typo (#5556) 2017-03-08 07:54:22 -05:00
AsciiWolf
dc6c3de1b6 docs: use https in the mailing list url 2017-03-07 12:33:51 -03:00
Zbigniew Jędrzejewski-Szmek
c2205a0d4f docs: add a note about reporting security vulns (#5541)
We *do* have the occasional security issue, where it would be nice to have
non-public disclosure and time to fix the issue before it's fully public. Our
github infrastracture does not make it easy to report vulnerabilities in
confidential manner, so let's leverage the distro mechanisms for that. I
think we're better off with this solution than leaving it up to individual
reporters to discover some mechanism on their own.
2017-03-07 14:33:27 +01:00
Peter Hutterer
f013e99e16 rules: set ID_BUS=bluetooth for any device with id/bustype attr of 0x0005 (#5539)
Not all bluetooth devices come through the bluetooth subsystem and those that
don't currently lack the ID_BUS=bluetooth env. This again fails to apply udev
rules and/or hwdb entries that rely on the bluetooth bustype to be set.

Fix this by checking the attribute id/bustype on the device instead of just
the subsystem.

Fixes #4566
2017-03-07 07:55:58 +01:00
AsciiWolf
7ebf71ee03 sd-bus: drop kdbus-related docs (#5533) 2017-03-07 07:51:35 +01:00
Thomas H. P. Andersen
557e36934d cgtop: use PRIu64 to print uint64_t (#5544)
Commit 59f448cf replaced usage of off_t with uint64_t. Change the
format string to use PRIu64 to match it.
2017-03-07 07:47:18 +01:00
Djalal Harouni
81687ee338 Merge pull request #5540 from keszybz/coredump-eof-fix
coredump: fix handling of premature-eof for --backtrace
2017-03-06 17:25:40 +01:00
Zbigniew Jędrzejewski-Szmek
d74dc4f2d0 coredump: fix handling of premature-eof data for --backtrace
We'd fail with an assert in journal_importer_process_data(),
because that function requires the caller to handle EOF themselves.
2017-03-05 10:35:44 -05:00
Djalal Harouni
77313738fe Merge pull request #5525 from martinpitt/khash-notsupp
test: skip instead of fail if crypto kmods are not available
2017-03-05 14:55:48 +01:00
Dax Kelson
055c521ad4 import: bump image size safety limit for machinectl pull (#5535)
We currenly use 40GB images in our environment
2017-03-05 13:03:53 +01:00
hadess
bf1c790c8f Merge pull request #5510 from phomes/accel-hwdb
hwdb: quirks for accelerometers in HP laptops
2017-03-04 15:35:25 +01:00
Thomas Hindoe Paaboel Andersen
128e6266ad hwdb: quirks for accelerometers in HP laptops
This patch adds quirks for the two laptops I could test on
(8540w and 8560w). The accelerometer is configured in the
kernel to report values according to the base of the laptop.
We want the values according to the screen instead.

It is likely (but untested) to match all HP laptops with the
lis3lv02d accelerometer on this list:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/platform/x86/hp_accel.c#n207
2017-03-03 21:35:57 +01:00
Thomas Hindoe Paaboel Andersen
3e021232da rules: allow quirks for platform input accelerometers 2017-03-03 21:23:39 +01:00
Martin Pitt
2e914f34eb test: skip instead of fail if crypto kmods are not available
Package build machines may have module loading disabled, thus AF_ALG
sockets are not available. Skip the tests that cover those (khash and
id128) instead of failing them in this case.

Fixes #5524
2017-03-03 16:45:44 +01:00
Michael Biebl
dcce98a4bd Avoid strict DM interface version dependencies (#5519)
Compiling against the dm-ioctl.h header as provided by the Linux kernel
will embed the DM interface version number. Running an older kernel can
result in an error like this on shutdown:

Could not detach DM dm-11: ioctl mismatch, kernel(4.34.4), user(4.35.4)

Work around this by shipping a local copy of dm-ioctl.h. We need at
least the version from 3.13 for DM_DEFERRED_REMOVE [1], so bump the
requirements in README accordingly.

[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=2c140a246dc0bc085b98eddde978060fcec1080c

Fixes: #5492
2017-03-02 19:11:37 +01:00
Zbigniew Jędrzejewski-Szmek
09c1102496 build-sys: do not require everything to be rebuild to push man pages (#5521)
When the doc-sync target was created, we didn't have man target yet.
2017-03-02 17:55:45 +01:00
Lennart Poettering
8cd23cd480 Merge pull request #5515 from glaubitz/master
Refine sub-architecture detection in basic/architecture
2017-03-02 17:54:13 +01:00
John Paul Adrian Glaubitz
9da2a0ac4e basic/architecture: Add sub-architecture types for SuperH
On SuperH, there are multiple sub-architectures defined with
different values for LIB_ARCH_TUPLE. The different sub-
architectures can be detected by checking whether __SH1__,
__SH2__, __SH3__, __SH4__, and so on are defined.
2017-03-02 10:29:43 +01:00
John Paul Adrian Glaubitz
202145c07a basic/architecture: Properly set LIB_ARCH_TUPLE for powerpcspe
On powerpc, there are two possible ABIs and hence values for
LIB_ARCH_TUPLE. The convential type with an FPU and the embedded
variant, called powerpcspe, which does not have a convential FPU
but a special Signal Processing Engine (SPE). The latter can be
detected by checking whether __NO_FPRS__ is defined.
2017-03-02 01:51:11 +01:00
John Paul Adrian Glaubitz
4c7c70c7c2 basic/architecture: Properly set LIB_ARCH_TUPLE for x32
On x86_64, there are two possible ABIs and hence values for
LIB_ARCH_TUPLE. The convential 64-bit type and the 32-bit
variant, called x32. The latter can be detected by checking
whether __ILP32__ is defined.
2017-03-02 01:50:36 +01:00
Zbigniew Jędrzejewski-Szmek
4317cf9026 Revert "environment.d: fix date"
This reverts commit 46987593cc.

Pushed to the wrong repo, sorry.
2017-03-01 19:27:54 -05:00
Zbigniew Jędrzejewski-Szmek
46987593cc environment.d: fix date 2017-03-01 19:27:09 -05:00
Lucas Werkmeister
c1ec34d1db NEWS: fix word (#5514) 2017-03-01 19:08:32 -05:00
Daniel Drake
ebf482e7cd hwdb: Endless ELT-NL3 accelerometer support
The Endless ELT-NL3 laptop has an accelerometer but its values are
not being interpreted correctly, meaning that it's very easy to end up
with the screen rotated inappropriately.

Add an appropriate mount matrix to correct the values.

P: /devices/LNXSYSTM:00/LNXSYBUS:00/ACCE0001:00
E: DEVPATH=/devices/LNXSYSTM:00/LNXSYBUS:00/ACCE0001:00
E: DRIVER=cmpc_accel_v4
E: ID_VENDOR_FROM_DATABASE=Accton Technology Corporation
E: MODALIAS=acpi:ACCE0001:
E: SUBSYSTEM=acpi

P: /devices/LNXSYSTM:00/LNXSYBUS:00/ACCE0001:00/input/input8
E: ABS=7
E: ACCEL_MOUNT_MATRIX=0, 1, 0; 0, 0, -1; -1, 0, 0
E: DEVPATH=/devices/LNXSYSTM:00/LNXSYBUS:00/ACCE0001:00/input/input8
E: EV=9
E: ID_FOR_SEAT=input-acpi-ACCE0001_00
E: ID_INPUT=1
E: ID_INPUT_ACCELEROMETER=1
E: ID_PATH=acpi-ACCE0001:00
E: ID_PATH_TAG=acpi-ACCE0001_00
E: IIO_SENSOR_PROXY_TYPE=input-accel
E: MODALIAS=input:b0000v0000p0000e0000-e0,3,kra0,1,2,mlsfw
E: NAME="cmpc_accel_v4"
E: PRODUCT=0/0/0/0
E: PROP=0
E: SUBSYSTEM=input
E: SYSTEMD_WANTS=iio-sensor-proxy.service
E: TAGS=💺systemd:

P: /devices/LNXSYSTM:00/LNXSYBUS:00/ACCE0001:00/input/input8/event7
N: input/event7
E: ACCEL_MOUNT_MATRIX=0, 1, 0; 0, 0, -1; -1, 0, 0
E: DEVNAME=/dev/input/event7
E: DEVPATH=/devices/LNXSYSTM:00/LNXSYBUS:00/ACCE0001:00/input/input8/event7
E: ID_INPUT=1
E: ID_INPUT_ACCELEROMETER=1
E: ID_PATH=acpi-ACCE0001:00
E: ID_PATH_TAG=acpi-ACCE0001_00
E: IIO_SENSOR_PROXY_TYPE=input-accel
E: MAJOR=13
E: MINOR=71
E: SUBSYSTEM=input
E: SYSTEMD_WANTS=iio-sensor-proxy.service
E: TAGS=:power-switch:systemd:
2017-03-02 00:02:22 +01:00
Daniel Drake
906d8a2ac5 udev: Allow quirks for ACPI input accelerometers
The existing accelerometer rules only support IIO devices, however
iio-sensor-proxy can also work with accelerometers made available
through the input (evdev) subsystem.

In this case I am working with an accelerometer input device backed by an
ACPI driver for which the hierarchy is:
- ACCE0001 (ACPI device)
  -> input8
    -> event7

We want the mount matrix (from hwdb) to be applied to both input8 and
event7. However, to match in 60-sensor.hwdb, we need to be working
with the modalias of the parent device (ACCE0001), and it is tricky
to access that when processing the input8 device which has it's own
modalias.

Instead of working directly with modalias, this ACPI-specific rule
uses the "hid" attribute to reconstruct the ACPI modalias. Since input
and event devices do not provide a hid attribute we will always get this
from the ACPI parent.

The modalias is constructed according to the definition in the kernel's
Documentation/acpi/namespace.txt and create_pnp_modalias(). We will only
use the first _CID/_HID value available, i.e. in some cases we will only
reconstruct the first part of the modalias, but that should be enough
granularity for our needs.
2017-03-02 00:02:22 +01:00
Lennart Poettering
268b6e1932 Merge pull request #5283 from poettering/tighten-sandbox
Tighten sandbox of long-running services
2017-03-01 23:35:06 +01:00
Lennart Poettering
d60c527009 NEWS: 'systemd' is always spelt with a lowercase 's' 2017-03-01 22:43:06 +01:00
Zbigniew Jędrzejewski-Szmek
4dfe64f856 NEWS: add note about 'make install-tests' (#5512) 2017-03-01 22:29:38 +01:00
Lennart Poettering
47ef78b27f Merge pull request #5502 from poettering/coredump-mini-fixes
Coredump mini improvments
2017-03-01 22:14:33 +01:00
Zbigniew Jędrzejewski-Szmek
23eb30b33e NEWS: reorder entries by subject, fix some typos and descriptions (#5511)
This doesn't add anything major, but moves some stuff around.
In particular changes which might require updates to the build
environment (new kernel requirements, cgroup stuff, dbus, etc)
are moved to the top, where it's most likely that people will
read them. In particular cgroup hierarchy changes are moved to the
top because they're most likely to be problematic.

Various items are grouped by subject where it's easy.

The description of list-jobs --after/--before was reversed.
2017-03-01 22:14:12 +01:00
Viktor Mihajlovski
fb92fbb1b1 udev: Use parent bus id for virtio disk builtin path-id (#5500)
The builtin path id for virtio block devices has been changed
to use the bus id without a prefix "virtio-pci" to be
compatible with all virtio transport types.

In order to not break existing setups, the by-path symlinks for
virtio block devices on the PCI bus are reintroduced by udev rules.
The virtio-pci symlinks are considered to be deprecated and
should be replaced by the native PCI symlinks.

Example output for a virtio disk in PCI slot 7:
 $ ls  /dev/disk/by-path
 pci-0000:00:07.0
 pci-0000:00:07.0-part1
 virtio-pci-0000:00:07.0
 virtio-pci-0000:00:07.0-part1

See also
[1] https://lists.freedesktop.org/archives/systemd-devel/2017-February/038326.html
[2] https://lists.freedesktop.org/archives/systemd-devel/2017-March/038397.html

This reverts f073b1b but keeps the same symlinks for compatibility.
2017-03-01 15:30:17 -05:00
Lucas Werkmeister
2a75df743b man: escape: fix --suffix examples (#5508)
systemd-escape does not permit the suffix to begin with a dot.
2017-03-01 15:24:18 -05:00
Lennart Poettering
d6d0473dc9 Revert "util: Fine tune running_in_chroot() a bit" (#5506)
This reverts commit 295ee9845c.

Let'd revert this for now, see #5446 for discussions.

We want systemd-detect-virt --chroot to return true for all chroot-like stuff, for
example mock environments which have use a mount namespace. The downside
of this revert that systemctl will not work from our own namespaced services, anything
with RootDirectory=/RootImage= set.
2017-03-01 15:22:02 -05:00
Lucas Werkmeister
b7a09e35cc man: systemd: fix description of SIGRTMIN+26,27,28 (#5505) 2017-03-01 18:33:02 +01:00
Lennart Poettering
501551e803 coredump: define a macro for a "short bus call timeout"
I think it would be a good idea to move such fixed, picked values out of
the main sources into the head of a file, to make sure they are
ultimately tunables.
2017-03-01 18:13:00 +01:00
Lennart Poettering
b8cda92df5 coredump: introduce is_journald_crash() and is_pid1_crash() helpers
We check these a number of times, hence let's unify these checks here.
This also allows us to make the PID 1 check more elaborate as we can
check both the PID and the cgroup. Checking the PID has the benefit that
we'll also cover cases where PID 1 might still be in the root cgroup, and
the cgroup check has the benefit that we also cover crashes in forked
off crasher processes (the way we actually do it in systemd)
2017-03-01 18:13:00 +01:00