systemd/coccinelle/empty-to-null.cocci

/* SPDX-License-Identifier: LGPL-2.1-or-later */
@@
/* Avoid running this transformation on the empty_to_null macro itself.
 * See the note in strempty.cocci to understand the weird magic below.
*/
position p : script:python() {
        not (p[0].file == "src/basic/string-util.h" and p[0].current_element == "something_else")
};
expression s;
@@

- isempty@p(s) ? NULL : s
+ empty_to_null(s)
licensing: add spdx to our .cocci files Since those are chunks of code based on our codebase, it's easiest to use the same license. 2021-10-01 13:28:36 +03:00			`/* SPDX-License-Identifier: LGPL-2.1-or-later */`
core: use empty_to_null() where we can 2017-12-07 14:13:00 +03:00			`@@`
coccinelle: skip the empty-to-null transformation on the macro itself Since the empty_to_null() function was "macrofied", we need to use a bit of black magic to make Coccinelle avoid running the transformation on the macro itself. Follow-up to ef2409cbde3. 2023-01-25 13:35:06 +03:00			`/* Avoid running this transformation on the empty_to_null macro itself.`
			`* See the note in strempty.cocci to understand the weird magic below.`
			`*/`
			`position p : script:python() {`
			`not (p[0].file == "src/basic/string-util.h" and p[0].current_element == "something_else")`
			`};`
core: use empty_to_null() where we can 2017-12-07 14:13:00 +03:00			`expression s;`
			`@@`
coccinelle: ignore function transformations causing recursion For example, following transformation: - isempty(s) ? NULL : s + empty_to_null(s) would get applied to the empty_to_null function itself as well, causing an infinite recursion, like: --- src/basic/string-util.h +++ /tmp/cocci-output-307-9f76e6-string-util.h @@ -50,11 +50,11 @@ static inline bool isempty(const char p } static inline const char empty_to_null(const char *p) { - return isempty(p) ? NULL : p; + return empty_to_null(p); } Let's avoid that by checking the current match position 2019-04-28 18:13:29 +03:00
			`- isempty@p(s) ? NULL : s`
core: use empty_to_null() where we can 2017-12-07 14:13:00 +03:00			`+ empty_to_null(s)`