systemd/coccinelle/mfree_return.cocci

@@
/* Avoid running this transformation on the mfree function itself */
position p : script:python() { p[0].current_element != "mfree" };
expression e;
@@
- free@p(e);
- return NULL;
+ return mfree(e);
tree-wide: use mfree more 2016-10-17 01:28:30 +03:00			`@@`
coccinelle: ignore function transformations causing recursion For example, following transformation: - isempty(s) ? NULL : s + empty_to_null(s) would get applied to the empty_to_null function itself as well, causing an infinite recursion, like: --- src/basic/string-util.h +++ /tmp/cocci-output-307-9f76e6-string-util.h @@ -50,11 +50,11 @@ static inline bool isempty(const char p } static inline const char empty_to_null(const char *p) { - return isempty(p) ? NULL : p; + return empty_to_null(p); } Let's avoid that by checking the current match position 2019-04-28 18:13:29 +03:00			`/* Avoid running this transformation on the mfree function itself */`
			`position p : script:python() { p[0].current_element != "mfree" };`
			`expression e;`
tree-wide: use mfree more 2016-10-17 01:28:30 +03:00			`@@`
coccinelle: ignore function transformations causing recursion For example, following transformation: - isempty(s) ? NULL : s + empty_to_null(s) would get applied to the empty_to_null function itself as well, causing an infinite recursion, like: --- src/basic/string-util.h +++ /tmp/cocci-output-307-9f76e6-string-util.h @@ -50,11 +50,11 @@ static inline bool isempty(const char p } static inline const char empty_to_null(const char *p) { - return isempty(p) ? NULL : p; + return empty_to_null(p); } Let's avoid that by checking the current match position 2019-04-28 18:13:29 +03:00			`- free@p(e);`
tree-wide: use mfree more 2016-10-17 01:28:30 +03:00			`- return NULL;`
coccinelle: ignore function transformations causing recursion For example, following transformation: - isempty(s) ? NULL : s + empty_to_null(s) would get applied to the empty_to_null function itself as well, causing an infinite recursion, like: --- src/basic/string-util.h +++ /tmp/cocci-output-307-9f76e6-string-util.h @@ -50,11 +50,11 @@ static inline bool isempty(const char p } static inline const char empty_to_null(const char *p) { - return isempty(p) ? NULL : p; + return empty_to_null(p); } Let's avoid that by checking the current match position 2019-04-28 18:13:29 +03:00			`+ return mfree(e);`