shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2024-12-23 21:35:11 +03:00
Code
9c6c4ad173
systemd/test/units/TEST-07-PID1.issue-30412.sh

33 lines
772 B
Bash
Raw Normal View History

executor: don't duplicate FD array to avoid double closing Just use ExecParam directly, as these are all internal to sd-exec now anyway. Avoids double close when execution fails after FDs are set up for inheritance and were already re-arranged. Fixes https://github.com/systemd/systemd/issues/30412
2023-12-11 04:03:39 +03:00
#!/usr/bin/env bash
# SPDX-License-Identifier: LGPL-2.1-or-later
set -eux
set -o pipefail
# Check that socket FDs are not double closed on error: https://github.com/systemd/systemd/issues/30412
mkdir -p /run/systemd/system
rm -f /tmp/badbin
touch /tmp/badbin
chmod 744 /tmp/badbin
cat >/run/systemd/system/badbin_assert.service <<EOF
[Service]
ExecStart=/tmp/badbin
test: "never" is not a valid value for Restart= [ 154.140565] testsuite-07.sh[1014]: + systemctl start badbin_assert.socket [ 154.738606] testsuite-07.sh[1014]: + socat - ABSTRACT-CONNECT:badbin_assert.socket [ 154.768418] systemd[1]: Cannot find unit for notify message of PID 1021, ignoring. [ 154.812357] systemd[1]: /run/systemd/system/badbin_assert.service:3: Failed to parse service restart specifier, ignoring: never [ 155.347350] testsuite-07.sh[1014]: + timeout 10 sh -c 'while systemctl is-active badbin_assert.service; do sleep .5; done' [ 155.669695] (badbin)[1045]: badbin_assert.service: Failed to execute /tmp/badbin: Exec format error [ 155.676596] systemd[1]: badbin_assert.service: Failed with result 'exit-code'. [ 156.081953] testsuite-07.sh[1051]: failed [ 156.132018] testsuite-07.sh[1054]: ++ systemctl show -P ExecMainStatus badbin_assert.service [ 156.326583] (badbin)[1050]: badbin_assert.service: Failed to execute /tmp/badbin: Exec format error [ 156.343566] systemd[1]: badbin_assert.service: Failed with result 'exit-code'. [ 156.904658] (badbin)[1055]: badbin_assert.service: Failed to execute /tmp/badbin: Exec format error [ 156.913709] systemd[1]: badbin_assert.service: Failed with result 'exit-code'. [ 157.066900] testsuite-07.sh[1014]: + [[ 0 == 203 ]] [ 157.081588] testsuite-07.sh[618]: + echo 'Subtest /usr/lib/systemd/tests/testdata/units/testsuite-07.issue-30412.sh failed' Follow-up for 1eeaa93de36.
2023-12-12 14:43:36 +03:00
Restart=no
executor: don't duplicate FD array to avoid double closing Just use ExecParam directly, as these are all internal to sd-exec now anyway. Avoids double close when execution fails after FDs are set up for inheritance and were already re-arranged. Fixes https://github.com/systemd/systemd/issues/30412
2023-12-11 04:03:39 +03:00
EOF
cat >/run/systemd/system/badbin_assert.socket <<EOF
[Socket]
ListenStream=@badbin_assert.socket
test: flush the socket once the triggered unit exits Since the triggered unit intentionally fails without consuming any data from the socket, we'd try to trigger it again and again, and we might try to check the unit state in one of the "in-between" states, failing the test: [ 165.271698] H testsuite-07.sh[1032]: + systemctl start badbin_assert.socket [ 165.977637] H testsuite-07.sh[1032]: + socat - ABSTRACT-CONNECT:badbin_assert.socket [ 165.983787] H systemd[1]: Cannot find unit for notify message of PID 1039, ignoring. [ 166.817187] H testsuite-07.sh[1032]: + timeout 10 sh -c 'while systemctl is-active badbin_assert.service; do sleep .5; done' [ 167.049218] H testsuite-07.sh[1065]: active [ 167.146854] H systemd[1]: Listening on badbin_assert.socket. [ 167.163473] H systemd[1]: badbin_assert.socket: Incoming traffic [ 167.542626] H systemd[1]: Cannot find unit for notify message of PID 1065, ignoring. [ 167.543437] H (badbin)[1062]: badbin_assert.service: Failed to execute /tmp/badbin: Exec format error [ 167.548346] H systemd[1]: badbin_assert.service: Main process exited, code=exited, status=203/EXEC [ 167.549482] H systemd[1]: badbin_assert.service: Failed with result 'exit-code'. [ 167.561537] H systemd[1]: badbin_assert.socket: Incoming traffic [ 167.933390] H systemd[1]: Started badbin_assert.service. [ 167.950489] H (badbin)[1070]: badbin_assert.service: Failed to execute /tmp/badbin: Exec format error [ 167.956318] H systemd[1]: badbin_assert.service: Main process exited, code=exited, status=203/EXEC [ 167.957173] H systemd[1]: badbin_assert.service: Failed with result 'exit-code'. [ 167.974609] H systemd[1]: badbin_assert.socket: Incoming traffic [ 168.042838] H testsuite-07.sh[1072]: failed [ 168.094431] H testsuite-07.sh[1075]: ++ systemctl show -P ExecMainStatus badbin_assert.service [ 168.704022] H systemd[1]: Started badbin_assert.service. [ 168.778680] H (badbin)[1074]: badbin_assert.service: Failed to execute /tmp/badbin: Exec format error [ 168.826881] H systemd[1]: badbin_assert.service: Main process exited, code=exited, status=203/EXEC [ 168.833825] H systemd[1]: badbin_assert.service: Failed with result 'exit-code'. [ 168.923931] H testsuite-07.sh[1032]: + [[ 0 == 203 ]] [ 168.951492] H systemd[1]: Cannot find unit for notify message of PID 1075, ignoring. [ 168.999862] H testsuite-07.sh[615]: + echo 'Subtest /usr/lib/systemd/tests/testdata/units/testsuite-07.issue-30412.sh failed' [ 168.999862] H testsuite-07.sh[615]: Subtest /usr/lib/systemd/tests/testdata/units/testsuite-07.issue-30412.sh failed Follow-up for 1eeaa93de36 and 28a2d27650c.
2023-12-24 14:53:53 +03:00
FlushPending=yes
executor: don't duplicate FD array to avoid double closing Just use ExecParam directly, as these are all internal to sd-exec now anyway. Avoids double close when execution fails after FDs are set up for inheritance and were already re-arranged. Fixes https://github.com/systemd/systemd/issues/30412
2023-12-11 04:03:39 +03:00
EOF
systemctl daemon-reload
systemctl start badbin_assert.socket
socat - ABSTRACT-CONNECT:badbin_assert.socket
timeout 10 sh -c 'while systemctl is-active badbin_assert.service; do sleep .5; done'
[[ "$(systemctl show -P ExecMainStatus badbin_assert.service)" == 203 ]]
Copy Permalink