shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2025-02-03 17:47:28 +03:00
Code
systemd/test/units/TEST-22-TMPFILES.05.sh

55 lines
1.3 KiB
Bash
Raw Normal View History

tmpfiles: use fd_get_path() even less excessively A follow-up for commit 9d874aec451b591401d9b14cf8743b9d179159b2. This patch makes "path" parameter mandatory in fd_set_*() helpers removing the need to use fd_get_path() when NULL was passed. The caller is supposed to pass the fd anyway so assuming that it also knows the path should be safe. Actually, the only case where this was useful (or used) was when we were walking through directory trees (in item_do()). But even in those cases the paths could be constructed trivially, which is still better than relying on fd_get_path() (which is an ugly API). A very succinct test case is also added for 'z/Z' operators so the code dealing with recursive operators is tested minimally.
2018-08-20 17:23:12 +02:00
#! /bin/bash
tests: add spdx headers to scripts and Makefiles
2021-10-17 18:13:06 +02:00
# SPDX-License-Identifier: LGPL-2.1-or-later
test: use set -eux and set -o pipefail everywhere This should make the scripts more robust.
2021-04-09 19:39:41 +02:00
set -eux
set -o pipefail
tmpfiles: use fd_get_path() even less excessively A follow-up for commit 9d874aec451b591401d9b14cf8743b9d179159b2. This patch makes "path" parameter mandatory in fd_set_*() helpers removing the need to use fd_get_path() when NULL was passed. The caller is supposed to pass the fd anyway so assuming that it also knows the path should be safe. Actually, the only case where this was useful (or used) was when we were walking through directory trees (in item_do()). But even in those cases the paths could be constructed trivially, which is still better than relying on fd_get_path() (which is an ugly API). A very succinct test case is also added for 'z/Z' operators so the code dealing with recursive operators is tested minimally.
2018-08-20 17:23:12 +02:00
rm -fr /tmp/{z,Z}
mkdir /tmp/{z,Z}
#
# 'z'
#
mkdir /tmp/z/d{1,2}
touch /tmp/z/f1 /tmp/z/d1/f11 /tmp/z/d2/f21
TEST-22: add --dry-run calls aCdDefLprRwxXz are tested with --dry-run. I added a primitive test of bc. There were no tests for AhHt, and I didn't add those either.
2023-12-08 10:17:04 +01:00
systemd-tmpfiles --dry-run --create - <<EOF
z /tmp/z/f1 0755 daemon daemon - -
z /tmp/z/d1 0755 daemon daemon - -
EOF
test "$(stat -c %U /tmp/z/f1)" = "$USER"
test "$(stat -c %U /tmp/z/d1)" = "$USER"
test "$(stat -c %U /tmp/z/d1/f11)" = "$USER"
tmpfiles: use fd_get_path() even less excessively A follow-up for commit 9d874aec451b591401d9b14cf8743b9d179159b2. This patch makes "path" parameter mandatory in fd_set_*() helpers removing the need to use fd_get_path() when NULL was passed. The caller is supposed to pass the fd anyway so assuming that it also knows the path should be safe. Actually, the only case where this was useful (or used) was when we were walking through directory trees (in item_do()). But even in those cases the paths could be constructed trivially, which is still better than relying on fd_get_path() (which is an ugly API). A very succinct test case is also added for 'z/Z' operators so the code dealing with recursive operators is tested minimally.
2018-08-20 17:23:12 +02:00
systemd-tmpfiles --create - <<EOF
z /tmp/z/f1 0755 daemon daemon - -
z /tmp/z/d1 0755 daemon daemon - -
EOF
test: use quotes where necessary to avoid possible word splitting.
2021-04-09 19:49:32 +02:00
test "$(stat -c %U:%G /tmp/z/f1)" = "daemon:daemon"
test "$(stat -c %U:%G /tmp/z/d1)" = "daemon:daemon"
test "$(stat -c %U:%G /tmp/z/d1/f11)" = "root:root"
tmpfiles: use fd_get_path() even less excessively A follow-up for commit 9d874aec451b591401d9b14cf8743b9d179159b2. This patch makes "path" parameter mandatory in fd_set_*() helpers removing the need to use fd_get_path() when NULL was passed. The caller is supposed to pass the fd anyway so assuming that it also knows the path should be safe. Actually, the only case where this was useful (or used) was when we were walking through directory trees (in item_do()). But even in those cases the paths could be constructed trivially, which is still better than relying on fd_get_path() (which is an ugly API). A very succinct test case is also added for 'z/Z' operators so the code dealing with recursive operators is tested minimally.
2018-08-20 17:23:12 +02:00
systemd-tmpfiles --create - <<EOF
z /tmp/z/d2/* 0755 daemon daemon - -
EOF
test: use quotes where necessary to avoid possible word splitting.
2021-04-09 19:49:32 +02:00
test "$(stat -c %U:%G /tmp/z/d2/f21)" = "daemon:daemon"
tmpfiles: use fd_get_path() even less excessively A follow-up for commit 9d874aec451b591401d9b14cf8743b9d179159b2. This patch makes "path" parameter mandatory in fd_set_*() helpers removing the need to use fd_get_path() when NULL was passed. The caller is supposed to pass the fd anyway so assuming that it also knows the path should be safe. Actually, the only case where this was useful (or used) was when we were walking through directory trees (in item_do()). But even in those cases the paths could be constructed trivially, which is still better than relying on fd_get_path() (which is an ugly API). A very succinct test case is also added for 'z/Z' operators so the code dealing with recursive operators is tested minimally.
2018-08-20 17:23:12 +02:00
#
# 'Z'
#
mkdir /tmp/Z/d1 /tmp/Z/d1/d11
touch /tmp/Z/f1 /tmp/Z/d1/f11 /tmp/Z/d1/d11/f111
systemd-tmpfiles --create - <<EOF
Z /tmp/Z/f1 0755 daemon daemon - -
Z /tmp/Z/d1 0755 daemon daemon - -
EOF
test: use quotes where necessary to avoid possible word splitting.
2021-04-09 19:49:32 +02:00
test "$(stat -c %U:%G /tmp/Z/f1)" = "daemon:daemon"
test "$(stat -c %U:%G /tmp/Z/d1)" = "daemon:daemon"
test "$(stat -c %U:%G /tmp/Z/d1/d11)" = "daemon:daemon"
test "$(stat -c %U:%G /tmp/Z/d1/f11)" = "daemon:daemon"
test "$(stat -c %U:%G /tmp/Z/d1/d11/f111)" = "daemon:daemon"
Copy Permalink