shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2024-12-26 03:22:00 +03:00
Code

networkd: add assert to appease coverity

Browse Source 
The code was OK, but not obviously so. Let's add an assert to help a
human or nonhuman reader figure it out.

Coverity CID#1433224.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek 2020-10-09 08:14:54 +02:00
parent b4c527f4ec
commit 081b300976
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/network/networkd-route.c
View File

@ -594,6 +594,7 @@ int route_remove(
if (!manager) if (!manager)
manager = link->manager; manager = link->manager;
/* link may be NULL! */
r = sd_rtnl_message_new_route(manager->rtnl, &req, r = sd_rtnl_message_new_route(manager->rtnl, &req,
RTM_DELROUTE, route->family, RTM_DELROUTE, route->family,
@ -676,6 +677,8 @@ int route_remove(
return log_link_error_errno(link, r, "Could not append RTA_PRIORITY attribute: %m"); return log_link_error_errno(link, r, "Could not append RTA_PRIORITY attribute: %m");
if (!IN_SET(route->type, RTN_UNREACHABLE, RTN_PROHIBIT, RTN_BLACKHOLE, RTN_THROW)) { if (!IN_SET(route->type, RTN_UNREACHABLE, RTN_PROHIBIT, RTN_BLACKHOLE, RTN_THROW)) {
assert(link); /* Those routes must be attached to a specific link */
r = sd_netlink_message_append_u32(req, RTA_OIF, link->ifindex); r = sd_netlink_message_append_u32(req, RTA_OIF, link->ifindex);
if (r < 0) if (r < 0)
return log_link_error_errno(link, r, "Could not append RTA_OIF attribute: %m"); return log_link_error_errno(link, r, "Could not append RTA_OIF attribute: %m");
@ -687,8 +690,7 @@ int route_remove(
if (r < 0) if (r < 0)
return log_link_error_errno(link, r, "Could not send rtnetlink message: %m"); return log_link_error_errno(link, r, "Could not send rtnetlink message: %m");
if (link) link_ref(link); /* link may be NULL, link_ref() is OK with that */
link_ref(link);
return 0; return 0;
} }