1
0
mirror of https://github.com/systemd/systemd.git synced 2025-01-09 01:18:19 +03:00

Get rid of strerror_safe()

This commit is contained in:
Zbigniew Jędrzejewski-Szmek 2022-10-07 15:59:34 +02:00
parent eaaf7465ee
commit 0cf1a4b3a7
2 changed files with 1 additions and 6 deletions

View File

@ -42,7 +42,7 @@ predicate potentiallyDangerousFunction(Function f, string message) {
message = "Call to ntohs() is confusing. Use be16toh() instead."
) or (
f.getQualifiedName() = "strerror" and
message = "Call to strerror() is not thread-safe. Use strerror_r() or printf()'s %m format string instead."
message = "Call to strerror() is not thread-safe. Use printf()'s %m format string or STRERROR() instead."
) or (
f.getQualifiedName() = "accept" and
message = "Call to accept() is not O_CLOEXEC-safe. Use accept4() instead."

View File

@ -73,11 +73,6 @@ static inline int RET_NERRNO(int ret) {
return ret;
}
static inline const char *strerror_safe(int error) {
/* 'safe' here does NOT mean thread safety. */
return strerror(abs(error));
}
static inline int errno_or_else(int fallback) {
/* To be used when invoking library calls where errno handling is not defined clearly: we return
* errno if it is set, and the specified error otherwise. The idea is that the caller initializes