shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2024-11-01 09:21:26 +03:00
Code

journalctl: replace string_erase with memset('x')

Browse Source 
The compiler should not be able to optimize out the memset, because optarg is global
memory. In this case, not making the argument an empty string is nicer, so just use
an open-coded version of string_erase from before the explicit_bzero change.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek 2017-02-05 20:09:41 -05:00
parent 2d26d8e07e
commit 1075122f42
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/journal/journalctl.c
View File

@ -686,7 +686,9 @@ static int parse_argv(int argc, char *argv[]) {
r = free_and_strdup(&arg_verify_key, optarg);
if (r < 0)
return r;
string_erase(optarg);
/* Use memset not string_erase so this doesn't look confusing
* in ps or htop output. */
memset(optarg, 'x', strlen(optarg));
arg_merge = false;
break;