shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2025-01-23 02:04:32 +03:00
Code

bootchart: Remove unneeded check for NULL

Browse Source 
Directly before the changed line there is:

	while ((parent->next_ps && parent->pid != ps->ppid))
		parent = parent->next_ps;

which looks one element ahead of the list, hence we can rely on parent
being non null here.
If 'parent' were NULL at that while loop already, it would crash as we're
dereferencing 'parent' when checking for next_ps already.

Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
This commit is contained in:
Stefan Beller 2013-12-30 00:09:56 +01:00 committed by Kay Sievers
parent 8181565124
commit 226b735a74
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/bootchart/store.c
View File

@ -345,7 +345,7 @@ schedstat_next:
while ((parent->next_ps && parent->pid != ps->ppid))
parent = parent->next_ps;
if ((!parent) || (parent->pid != ps->ppid)) {
if (parent->pid != ps->ppid) {
/* orphan */
ps->ppid = 1;
parent = ps_first->next_ps;