shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2025-03-31 14:50:15 +03:00
Code

Merge pull request #18703 from poettering/cgroupsv1-bad

Browse Source 
consider cgroupsv1 usage grounds for "tainting"
This commit is contained in:
Zbigniew Jędrzejewski-Szmek 2021-02-19 18:25:17 +01:00 committed by GitHub
commit 27a54998f4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
man/systemd.service.xml
View File

@ -292,7 +292,11 @@
will remove the file after the service has shut down if it still exists. The PID file does not need to be owned
by a privileged user, but if it is owned by an unprivileged user additional safety restrictions are enforced:
the file may not be a symlink to a file owned by a different user (neither directly nor indirectly), and the
PID file must refer to a process already belonging to the service.</para></listitem>
PID file must refer to a process already belonging to the service.</para>
<para>Note that PID files should be avoided in modern projects. Use <option>Type=notify</option> or
<option>Type=simple</option> where possible, which does not require use of PID files to determine the
main process of a service and avoids needless forking.</para></listitem>
</varlistentry>
<varlistentry>

4
src/core/manager.c
View File

@ -4799,6 +4799,7 @@ char *manager_taint_string(Manager *m) {
buf = new(char, sizeof("split-usr:"
"cgroups-missing:"
"cgrousv1:"
"local-hwclock:"
"var-run-bad:"
"overflowuid-not-65534:"
@ -4815,6 +4816,9 @@ char *manager_taint_string(Manager *m) {
if (access("/proc/cgroups", F_OK) < 0)
e = stpcpy(e, "cgroups-missing:");
if (cg_all_unified() == 0)
e = stpcpy(e, "cgroupsv1:");
if (clock_is_localtime(NULL) > 0)
e = stpcpy(e, "local-hwclock:");