shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2025-03-22 06:50:18 +03:00
Code

coredump: normalize generation/parsing of COREDUMP_TRUNCATED=

Browse Source 
Given that this is a field primarily processed by computers, and not so
much by humans, assign "1" instead of "yes". Also, use parse_boolean()
as we usually do for parsing it again.

This makes things more alike udev options (as one example), such as
SYSTEMD_READY where we also spit out "1" and "0", and parse with
parse_boolean().
This commit is contained in:
Lennart Poettering 2017-03-01 15:46:54 +01:00
parent 059c35f507
commit 32a1575fbd
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/coredump/coredump.c
View File

@ -795,7 +795,7 @@ log:
IOVEC_SET_STRING(iovec[n_iovec++], core_message);
if (truncated)
IOVEC_SET_STRING(iovec[n_iovec++], "COREDUMP_TRUNCATED=yes");
IOVEC_SET_STRING(iovec[n_iovec++], "COREDUMP_TRUNCATED=1");
/* Optionally store the entire coredump in the journal */
if (arg_storage == COREDUMP_STORAGE_JOURNAL) {

8
src/coredump/coredumpctl.c
View File

@ -414,7 +414,7 @@ static int print_list(FILE* file, sd_journal *j, int had_legend) {
else
present = "-";
if (STR_IN_SET(present, "present", "journal") && streq_ptr(truncated, "yes"))
if (STR_IN_SET(present, "present", "journal") && truncated && parse_boolean(truncated) > 0)
present = "truncated";
fprintf(file, "%-*s %*s %*s %*s %*s %-*s %s\n",
@ -583,8 +583,10 @@ static int print_info(FILE *file, sd_journal *j, bool need_space) {
fprintf(file, " Hostname: %s\n", hostname);
if (filename) {
bool inacc = access(filename, R_OK) < 0;
bool trunc = streq_ptr(truncated, "yes");
bool inacc, trunc;
inacc = access(filename, R_OK) < 0;
trunc = truncated && parse_boolean(truncated) > 0;
if (inacc || trunc)
fprintf(file, " Storage: %s%s (%s%s%s)%s\n",