From 36e7aa70107cc87369c6d21d0cb47e9fc9ca7cb5 Mon Sep 17 00:00:00 2001 From: Lennart Poettering <lennart@poettering.net> Date: Tue, 7 Jan 2025 14:46:00 +0100 Subject: [PATCH] varlink: drop redundant check sd_varlink_dispatch() alredy validates all this, no need to check this manually. --- src/shared/varlink-io.systemd.service.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/shared/varlink-io.systemd.service.c b/src/shared/varlink-io.systemd.service.c index c369ad2646c..27c270b8e96 100644 --- a/src/shared/varlink-io.systemd.service.c +++ b/src/shared/varlink-io.systemd.service.c @@ -53,11 +53,6 @@ int varlink_method_set_log_level(sd_varlink *link, sd_json_variant *parameters, assert(link); assert(parameters); - /* NOTE: The method does have 1 parameter, but we must compare to 2 here, because - * sd_json_variant_elements() breaks abstraction and exposes internal structure of JsonObject. */ - if (sd_json_variant_elements(parameters) != 2) - return sd_varlink_error_invalid_parameter(link, parameters); - r = sd_varlink_dispatch(link, parameters, dispatch_table, &level); if (r != 0) return r;