1
0
mirror of https://github.com/systemd/systemd.git synced 2024-12-23 21:35:11 +03:00

test-unit-name: fix fd leak

Fixes an issue reported at https://github.com/systemd/systemd/issues/22576#issuecomment-1396774385.
This commit is contained in:
Yu Watanabe 2023-01-20 14:54:44 +09:00
parent 86d82cb888
commit 36f73b6c67

View File

@ -242,11 +242,13 @@ TEST_RET(unit_printf, .sd_booted = true) {
*user, *group, *uid, *gid, *home, *shell, *user, *group, *uid, *gid, *home, *shell,
*tmp_dir, *var_tmp_dir; *tmp_dir, *var_tmp_dir;
_cleanup_(manager_freep) Manager *m = NULL; _cleanup_(manager_freep) Manager *m = NULL;
_cleanup_close_ int fd = -EBADF;
Unit *u; Unit *u;
int r; int r;
_cleanup_(unlink_tempfilep) char filename[] = "/tmp/test-unit_printf.XXXXXX"; _cleanup_(unlink_tempfilep) char filename[] = "/tmp/test-unit_printf.XXXXXX";
assert_se(mkostemp_safe(filename) >= 0); fd = mkostemp_safe(filename);
assert_se(fd >= 0);
/* Using the specifier functions is admittedly a bit circular, but we don't want to reimplement the /* Using the specifier functions is admittedly a bit circular, but we don't want to reimplement the
* logic a second time. We're at least testing that the hookup works. */ * logic a second time. We're at least testing that the hookup works. */