shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2025-01-10 05:18:17 +03:00
Code

pty: optimize read loop

Browse Source 
As it turns out, I can actually send data to the pty faster than the
terminal can read. Therefore, make sure we read as much data as possible
but bail out early enough to not cause starvation.

Kernel TTY buffers are 4k, so reduce the overall buffer size, but read
more than once if possible (up to 8 times sounds reasonable).
This commit is contained in:
David Herrmann 2014-10-03 15:54:21 +02:00
parent ce04e2335a
commit 48fed5c55b
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/shared/pty.c
View File

@ -67,7 +67,7 @@
#include "ring.h"
#include "util.h"
#define PTY_BUFSIZE 16384
#define PTY_BUFSIZE 4096
enum {
PTY_ROLE_UNKNOWN,
@ -305,11 +305,11 @@ static int pty_dispatch_read(Pty *pty) {
/*
* We're edge-triggered, means we need to read the whole queue. This,
* however, might cause us to stall if the writer is faster than we
* are. Therefore, we read twice and if the second read still returned
* data, we reschedule.
* are. Therefore, try reading as much as 8 times (32KiB) and only
* bail out then.
*/
for (i = 0; i < 2; ++i) {
for (i = 0; i < 8; ++i) {
len = read(pty->fd, pty->in_buf, sizeof(pty->in_buf) - 1);
if (len < 0) {
if (errno == EINTR)