shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2025-03-24 14:50:17 +03:00
Code

install: allow removing symlinks even for units that are gone

Browse Source 
If a symlink is leftover, still allow cleaning it up via 'disable'. This
happens when a unit is stopped and removed, but not disabled, and a reload
has already happened. At that point, cleaning up the old symlinks becomes
impossible through the APIs, and needs to be done manually. Always allow
cleaning up symlinks, if they exist, by only erroring out if there is an
OOM.

Follow-up for f31f10a6207efc9ae9e0b1f73975b5b610914017
This commit is contained in:
Luca Boccassi 2024-06-07 21:39:45 +01:00 committed by Lennart Poettering
parent 7c6028bbcb
commit 5163c9b1e5
2 changed files with 16 additions and 4 deletions
src/shared
install.c
test/units
TEST-26-SYSTEMCTL.sh

14
src/shared/install.c

@ -2279,7 +2279,9 @@ static int install_context_mark_for_removal(
else {
log_debug_errno(r, "Unit %s not found, removing name.", i->name);
r = install_changes_add(changes, n_changes, r, i->path ?: i->name, NULL);
if (r < 0)
/* In case there's no unit, we still want to remove any leftover symlink, even if
* the unit might have been removed already, hence treating ENOENT as non-fatal. */
if (r != -ENOENT)
return r;
}
} else if (r < 0) {
@ -2873,9 +2875,13 @@ static int do_unit_file_disable(
r = install_info_add(&ctx, *name, NULL, lp->root_dir, /* auxiliary= */ false, &info);
if (r >= 0)
r = install_info_traverse(&ctx, lp, info, SEARCH_LOAD|SEARCH_FOLLOW_CONFIG_SYMLINKS, NULL);
if (r < 0)
return install_changes_add(changes, n_changes, r, *name, NULL);
if (r < 0) {
r = install_changes_add(changes, n_changes, r, *name, NULL);
/* In case there's no unit, we still want to remove any leftover symlink, even if
* the unit might have been removed already, hence treating ENOENT as non-fatal. */
if (r != -ENOENT)
return r;
}
/* If we enable multiple units, some with install info and others without,
* the "empty [Install] section" warning is not shown. Let's make the behavior

6
test/units/TEST-26-SYSTEMCTL.sh

@ -343,6 +343,12 @@ systemctl cat "$UNIT_NAME"
systemctl help "$UNIT_NAME"
systemctl service-watchdogs
systemctl service-watchdogs "$(systemctl service-watchdogs)"
# Ensure that the enablement symlinks can still be removed after the user is gone, to avoid having leftovers
systemctl enable "$UNIT_NAME"
systemctl stop "$UNIT_NAME"
rm -f "/usr/lib/systemd/system/$UNIT_NAME"
systemctl daemon-reload
systemctl disable "$UNIT_NAME"
# show/set-environment
# Make sure PATH is set