From 6388c31525eff90aadddad448217fa92232890ca Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Mon, 23 Jun 2014 15:53:03 +0200 Subject: [PATCH] coredump: quit early if we cannot store ay coredump to disk --- src/journal/coredump.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/journal/coredump.c b/src/journal/coredump.c index 287e0ed7fdd..764c5e72ab3 100644 --- a/src/journal/coredump.c +++ b/src/journal/coredump.c @@ -39,6 +39,7 @@ #include "conf-parser.h" #include "copy.h" #include "stacktrace.h" +#include "path-util.h" #ifdef HAVE_ACL #include @@ -375,6 +376,13 @@ int main(int argc, char* argv[]) { parse_config(); log_debug("Selected storage '%s'.", coredump_storage_to_string(arg_storage)); + /* Exit early if we cannot write the coredump to disk anyway */ + if (path_is_read_only_fs("/var/lib") != 0) { + log_error("Coredump directory not mounted or not writable, skipping coredump."); + r = -EROFS; + goto finish; + } + r = parse_uid(argv[ARG_UID], &uid); if (r < 0) { log_error("Failed to parse UID.");