1
0
mirror of https://github.com/systemd/systemd.git synced 2024-12-22 17:35:35 +03:00

busctl: add --num-matches= for monitor verb

Useful in scripts when one wants to wait for a specific
signal before continuing
This commit is contained in:
Luca Boccassi 2024-08-07 21:59:26 +01:00
parent 989e843e75
commit 702d74b62a
5 changed files with 36 additions and 2 deletions

View File

@ -406,6 +406,19 @@
</listitem> </listitem>
</varlistentry> </varlistentry>
<varlistentry>
<term><option>--num-matches=<replaceable>NUMBER</replaceable></option></term>
<listitem>
<para>When used with the <command>monitor</command> command, if enabled will make
<command>busctl</command> exit when the specified number of messages have been received and
printed. This is useful in combination with <option>--match=</option>, to wait for the specified
number of occurrences of specific D-Bus messages.</para>
<xi:include href="version-info.xml" xpointer="v257"/>
</listitem>
</varlistentry>
<varlistentry> <varlistentry>
<term><option>--augment-creds=<replaceable>BOOL</replaceable></option></term> <term><option>--augment-creds=<replaceable>BOOL</replaceable></option></term>

View File

@ -89,7 +89,7 @@ _busctl() {
--allow-interactive-authorization=no --augment-creds=no --allow-interactive-authorization=no --augment-creds=no
--watch-bind=yes -j -l --full --xml-interface' --watch-bind=yes -j -l --full --xml-interface'
[ARG]='--address -H --host -M --machine --match --timeout --size --json [ARG]='--address -H --host -M --machine --match --timeout --size --json
--destination' --destination --num-matches'
) )
if __contains_word "--user" ${COMP_WORDS[*]}; then if __contains_word "--user" ${COMP_WORDS[*]}; then

View File

@ -284,4 +284,5 @@ _arguments \
'--allow-interactive-authorization=[Allow interactive authorization for operation]:boolean:(1 0)' \ '--allow-interactive-authorization=[Allow interactive authorization for operation]:boolean:(1 0)' \
'--timeout=[Maximum time to wait for method call completion and monitoring]:timeout (seconds)' \ '--timeout=[Maximum time to wait for method call completion and monitoring]:timeout (seconds)' \
'--augment-creds=[Extend credential data with data read from /proc/$PID]:boolean:(1 0)' \ '--augment-creds=[Extend credential data with data read from /proc/$PID]:boolean:(1 0)' \
'--num-matches=[Exit after receiving a number of matches while monitoring]:integer' \
'*::busctl command:_busctl_commands' '*::busctl command:_busctl_commands'

View File

@ -63,6 +63,7 @@ static bool arg_augment_creds = true;
static bool arg_watch_bind = false; static bool arg_watch_bind = false;
static usec_t arg_timeout = 0; static usec_t arg_timeout = 0;
static const char *arg_destination = NULL; static const char *arg_destination = NULL;
static uint64_t arg_num_matches = UINT64_MAX;
STATIC_DESTRUCTOR_REGISTER(arg_matches, strv_freep); STATIC_DESTRUCTOR_REGISTER(arg_matches, strv_freep);
@ -1361,6 +1362,12 @@ static int monitor(int argc, char **argv, int (*dump)(sd_bus_message *m, FILE *f
dump(m, stdout); dump(m, stdout);
fflush(stdout); fflush(stdout);
if (arg_num_matches != UINT64_MAX && --arg_num_matches == 0) {
if (!arg_quiet && arg_json_format_flags == SD_JSON_FORMAT_OFF)
log_info("Received requested number of matching messages, exiting.");
return 0;
}
if (sd_bus_message_is_signal(m, "org.freedesktop.DBus.Local", "Disconnected") > 0) { if (sd_bus_message_is_signal(m, "org.freedesktop.DBus.Local", "Disconnected") > 0) {
if (!arg_quiet && arg_json_format_flags == SD_JSON_FORMAT_OFF) if (!arg_quiet && arg_json_format_flags == SD_JSON_FORMAT_OFF)
log_info("Connection terminated, exiting."); log_info("Connection terminated, exiting.");
@ -2361,6 +2368,8 @@ static int help(void) {
" --watch-bind=BOOL Wait for bus AF_UNIX socket to be bound in the file\n" " --watch-bind=BOOL Wait for bus AF_UNIX socket to be bound in the file\n"
" system\n" " system\n"
" --destination=SERVICE Destination service of a signal\n" " --destination=SERVICE Destination service of a signal\n"
" --num-matches=NUMBER Exit after receiving a number of matches while\n"
" monitoring\n"
"\nSee the %s for details.\n", "\nSee the %s for details.\n",
program_invocation_short_name, program_invocation_short_name,
ansi_highlight(), ansi_highlight(),
@ -2400,6 +2409,7 @@ static int parse_argv(int argc, char *argv[]) {
ARG_WATCH_BIND, ARG_WATCH_BIND,
ARG_JSON, ARG_JSON,
ARG_DESTINATION, ARG_DESTINATION,
ARG_NUM_MATCHES,
}; };
static const struct option options[] = { static const struct option options[] = {
@ -2432,6 +2442,7 @@ static int parse_argv(int argc, char *argv[]) {
{ "watch-bind", required_argument, NULL, ARG_WATCH_BIND }, { "watch-bind", required_argument, NULL, ARG_WATCH_BIND },
{ "json", required_argument, NULL, ARG_JSON }, { "json", required_argument, NULL, ARG_JSON },
{ "destination", required_argument, NULL, ARG_DESTINATION }, { "destination", required_argument, NULL, ARG_DESTINATION },
{ "num-matches", required_argument, NULL, ARG_NUM_MATCHES },
{}, {},
}; };
@ -2600,6 +2611,15 @@ static int parse_argv(int argc, char *argv[]) {
arg_destination = optarg; arg_destination = optarg;
break; break;
case ARG_NUM_MATCHES:
r = safe_atou64(optarg, &arg_num_matches);
if (r < 0)
return log_error_errno(r, "Failed to parse --num-matches= parameter '%s': %m", optarg);
if (arg_num_matches == 0)
return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "--num-matches= parameter cannot be 0");
break;
case '?': case '?':
return -EINVAL; return -EINVAL;

View File

@ -109,4 +109,4 @@ busctl get-property -j \
(! busctl set-property org.freedesktop.systemd1 /org/freedesktop/systemd1 org.freedesktop.systemd1.Manager \ (! busctl set-property org.freedesktop.systemd1 /org/freedesktop/systemd1 org.freedesktop.systemd1.Manager \
KExecWatchdogUSec t "foo") KExecWatchdogUSec t "foo")
busctl --quiet --timeout 1 --match "interface=org.freedesktop.systemd1.Manager" monitor >/dev/null busctl --quiet --timeout 1 --num-matches 1 --match "interface=org.freedesktop.systemd1.Manager" monitor >/dev/null