shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2024-11-01 17:51:22 +03:00
Code

core: allow changing the description for units dynamically at runtime

Browse Source 
This makes "systemctl set-property foobar.service Description=waldo"
work.

See: #7245
This commit is contained in:
Lennart Poettering 2017-11-22 16:34:56 +01:00
parent e74f76ca86
commit 721060d446
1 changed files with 28 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/core/dbus-unit.c
View File

@ -1315,7 +1315,7 @@ int bus_unit_queue_job(
return sd_bus_reply_method_return(message, "o", path);
}
static int bus_unit_set_transient_property(
static int bus_unit_set_live_property(
Unit *u,
const char *name,
sd_bus_message *message,
@ -1328,6 +1328,9 @@ static int bus_unit_set_transient_property(
assert(name);
assert(message);
/* Handles setting properties both "live" (i.e. at any time during runtime), and during creation (for transient
* units that are being created). */
if (streq(name, "Description")) {
const char *d;
@ -1344,8 +1347,28 @@ static int bus_unit_set_transient_property(
}
return 1;
}
} else if (streq(name, "DefaultDependencies")) {
return 0;
}
static int bus_unit_set_transient_property(
Unit *u,
const char *name,
sd_bus_message *message,
UnitWriteFlags flags,
sd_bus_error *error) {
int r;
assert(u);
assert(name);
assert(message);
/* Handles settings when transient units are created. This settings cannot be altered anymore after the unit
* has been created. */
if (streq(name, "DefaultDependencies")) {
int b;
r = sd_bus_message_read(message, "b", &b);
@ -1583,8 +1606,11 @@ int bus_unit_set_properties(
r = UNIT_VTABLE(u)->bus_set_property(u, name, message, f, error);
if (r == 0 && u->transient && u->load_state == UNIT_STUB)
r = bus_unit_set_transient_property(u, name, message, f, error);
if (r == 0)
r = bus_unit_set_live_property(u, name, message, f, error);
if (r < 0)
return r;
if (r == 0)
return sd_bus_error_setf(error, SD_BUS_ERROR_PROPERTY_READ_ONLY, "Cannot set property %s, or unknown property.", name);