From 7489d0640a4864d4b47fd8fda77f8eb7cf2e3fe8 Mon Sep 17 00:00:00 2001 From: Luca Boccassi Date: Thu, 25 Mar 2021 11:47:13 +0000 Subject: [PATCH] test-dhcp6-client: add one more assert on memory mapping Static analyzers need a hint that optval is not pointing off the end of the msg_advertise array, since pos can go up to the full length of it. The array is manually constructed so we know this won't happen, but adding one more assert should be enough to avoid false positives. Coverity CID #1394277 --- src/libsystemd-network/test-dhcp6-client.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libsystemd-network/test-dhcp6-client.c b/src/libsystemd-network/test-dhcp6-client.c index cb363b3973f..42cd91e0be3 100644 --- a/src/libsystemd-network/test-dhcp6-client.c +++ b/src/libsystemd-network/test-dhcp6-client.c @@ -449,6 +449,7 @@ static int test_advertise_option(sd_event *e) { case SD_DHCP6_OPTION_IA_NA: assert_se(optlen == 94); + assert_se(optval == &msg_advertise[26]); assert_se(!memcmp(optval, &msg_advertise[26], optlen)); val = htobe32(0x0ecfa37d);