Merge pull request #34742 from yuwata/test-storage

test: fix multipath test in TEST-64-STORAGE

mkosi.conf.d/10-debian-ubuntu/mkosi.conf

@@ -4,8 +4,8 @@
 Distribution=|debian
 Distribution=|ubuntu
 
-[Distribution]
-PackageManagerTrees=mkosi-pinning.pref:/etc/apt/preferences.d/mkosi-pinning.pref
+[Build]
+SandboxTrees=mkosi-pinning.pref:/etc/apt/preferences.d/mkosi-pinning.pref
 
 [Content]
 VolatilePackages=

mkosi.conf.d/10-opensuse/mkosi.conf

@@ -6,7 +6,9 @@ Distribution=opensuse
 [Distribution]
 Release=tumbleweed
 Repositories=non-oss
-PackageManagerTrees=macros.db_backend:/etc/rpm/macros.db_backend
+
+[Build]
+SandboxTrees=macros.db_backend:/etc/rpm/macros.db_backend
 
 [Content]
 VolatilePackages=

mkosi.conf.d/10-ubuntu/mkosi.conf.d/non-x86.conf

@@ -6,5 +6,5 @@ Architecture=!x86-64
 Architecture=!x86
 Release=noble
 
-[Distribution]
-PackageManagerTrees=noble-backports-ports.sources:/etc/apt/sources.list.d/noble-backports-ports.sources
+[Build]
+SandboxTrees=noble-backports-ports.sources:/etc/apt/sources.list.d/noble-backports-ports.sources

mkosi.conf.d/10-ubuntu/mkosi.conf.d/x86.conf

@@ -6,5 +6,5 @@ Architecture=|x86-64
 Architecture=|x86
 Release=noble
 
-[Distribution]
-PackageManagerTrees=noble-backports.sources:/etc/apt/sources.list.d/noble-backports.sources
+[Build]
+SandboxTrees=noble-backports.sources:/etc/apt/sources.list.d/noble-backports.sources

test/README.testsuite

@@ -25,7 +25,7 @@ Environment=NO_BUILD=1
 You might also want to use the `PackageDirectories=` or `Repositories=` option to provide
 mkosi with a directory or repository containing the systemd packages that should be installed
 instead. If the repository containing the systemd packages is not a builtin repository known
-by mkosi, you can use the `PackageManagerTrees=` option to write an extra repository definition
+by mkosi, you can use the `SandboxTrees=` option to write an extra repository definition
 to /etc which is used when building the image instead.
 
 Next, we can build the integration test image with meson:

test/units/TEST-58-REPART.sh

@@ -4,9 +4,6 @@
 set -eux
 set -o pipefail
 
-# shellcheck source=test/units/util.sh
-. "$(dirname "$0")"/util.sh
-
 if ! command -v systemd-repart >/dev/null; then
     echo "no systemd-repart" >/skipped
     exit 77

test/units/TEST-64-UDEV-STORAGE.sh

@@ -290,15 +290,21 @@ label: gpt
 name="first_partition", size=5M
 uuid="deadbeef-dead-dead-beef-000000000000", name="failover_part", size=5M
 EOF
+    # Partitioning triggers a synthesized event. Wait for the event being finished.
     udevadm settle
+
     udevadm lock --device /dev/disk/by-id/wwn-0xdeaddeadbeef0000-part2 \
             mkfs.ext4 -U "deadbeef-dead-dead-beef-111111111111" -L "failover_vol" /dev/disk/by-id/wwn-0xdeaddeadbeef0000-part2
+    # Making filesystem triggers a synthesized event. Wait for the event being finished.
+    udevadm settle
 
     modprobe -v dm_multipath
     systemctl start multipathd.service
     systemctl status multipathd.service
-    multipath -ll
+    # multipathd touches many devices on start. multipath command may fail if it is invoked before the
+    # initial setup finished. Let's wait for a while.
     udevadm settle
+    multipath -ll
     ls -l /dev/disk/by-id/
 
     for i in {0..15}; do