shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2025-01-12 13:18:14 +03:00
Code

core/service: also reject deserialized commands with no argv[0]

Browse Source 
I'm pretty sure that bad things would happen later on.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek 2021-04-23 12:40:07 +02:00
parent 1a128a468d
commit 9020479246
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/core/service.c
View File

@ -2790,13 +2790,14 @@ static int service_deserialize_exec_command(
return -ENOMEM;
break;
default:
assert_not_reached("Unknown error at deserialization of exec command");
break;
assert_not_reached("Logic error in exec command deserialization");
}
}
if (state != STATE_EXEC_COMMAND_ARGS)
return -EINVAL;
if (strv_isempty(argv))
return -EINVAL; /* At least argv[0] must be always present. */
/* Let's check whether exec command on given offset matches data that we just deserialized */
for (command = s->exec_command[id], i = 0; command; command = command->command_next, i++) {