diff --git a/man/custom-entities.ent.in b/man/custom-entities.ent.in index e2bd44e5e78..85805777a0d 100644 --- a/man/custom-entities.ent.in +++ b/man/custom-entities.ent.in @@ -8,3 +8,4 @@ + diff --git a/man/systemd-debug-generator.xml b/man/systemd-debug-generator.xml index 1f9a79db82f..305dc2ff371 100644 --- a/man/systemd-debug-generator.xml +++ b/man/systemd-debug-generator.xml @@ -1,7 +1,10 @@ + "http://www.oasis-open.org/docbook/xml/4.2/docbookx.dtd" [ + +%entities; +]> @@ -56,9 +59,10 @@ option is specified, the debug shell service debug-shell.service is pulled into the boot - transaction. It will spawn a debug shell on tty9 during early - system startup. Note that the shell may also be turned on - persistently by enabling it with + transaction and a debug shell will be spawned during early boot. + By default, &DEBUGTTY; is used, but a specific tty can also be set, + either with or without the /dev/ prefix. + Note that the shell may also be turned on persistently by enabling it with systemctl1's enable command. is honored only by initial diff --git a/meson.build b/meson.build index c60c4ab873a..3988fb76bde 100644 --- a/meson.build +++ b/meson.build @@ -789,6 +789,7 @@ conf.set_quoted('GETTEXT_PACKAGE', meson.project_name()) substs.set('SUSHELL', get_option('debug-shell')) substs.set('DEBUGTTY', get_option('debug-tty')) +conf.set_quoted('DEBUGTTY', get_option('debug-tty')) enable_debug_hashmap = false enable_debug_mmap_cache = false diff --git a/src/debug-generator/debug-generator.c b/src/debug-generator/debug-generator.c index 5faf8d7ddf4..09220dc98c7 100644 --- a/src/debug-generator/debug-generator.c +++ b/src/debug-generator/debug-generator.c @@ -3,6 +3,7 @@ #include #include "alloc-util.h" +#include "dropin.h" #include "generator.h" #include "mkdir.h" #include "parse-util.h" @@ -17,11 +18,12 @@ static const char *arg_dest = NULL; static char *arg_default_unit = NULL; static char **arg_mask = NULL; static char **arg_wants = NULL; -static bool arg_debug_shell = false; +static char *arg_debug_shell = NULL; STATIC_DESTRUCTOR_REGISTER(arg_default_unit, freep); STATIC_DESTRUCTOR_REGISTER(arg_mask, strv_freep); STATIC_DESTRUCTOR_REGISTER(arg_wants, strv_freep); +STATIC_DESTRUCTOR_REGISTER(arg_debug_shell, freep); static int parse_proc_cmdline_item(const char *key, const char *value, void *data) { int r; @@ -57,15 +59,16 @@ static int parse_proc_cmdline_item(const char *key, const char *value, void *dat return log_oom(); } else if (proc_cmdline_key_streq(key, "systemd.debug_shell")) { + const char *t = NULL; - if (value) { - r = parse_boolean(value); - if (r < 0) - log_error("Failed to parse systemd.debug_shell= argument '%s', ignoring.", value); - else - arg_debug_shell = r; - } else - arg_debug_shell = true; + r = value ? parse_boolean(value) : 1; + if (r < 0) + t = skip_dev_prefix(value); + else if (r > 0) + t = skip_dev_prefix(DEBUGTTY); + + if (free_and_strdup(&arg_debug_shell, t) < 0) + return log_oom(); } else if (streq(key, "systemd.unit")) { @@ -143,6 +146,23 @@ static int generate_wants_symlinks(void) { return r; } +static void install_debug_shell_dropin(const char *dir) { + int r; + + if (streq(arg_debug_shell, skip_dev_prefix(DEBUGTTY))) + return; + + r = write_drop_in_format(dir, "debug-shell.service", 50, "tty", + "[Unit]\n" + "Description=Early root shell on /dev/%s FOR DEBUGGING ONLY\n" + "ConditionPathExists=\n" + "[Service]\n" + "TTYPath=/dev/%s", + arg_debug_shell, arg_debug_shell); + if (r < 0) + log_warning_errno(r, "Failed to write drop-in for debug-shell.service, ignoring: %m"); +} + static int run(const char *dest, const char *dest_early, const char *dest_late) { int r, q; @@ -156,6 +176,8 @@ static int run(const char *dest, const char *dest_early, const char *dest_late) r = strv_extend(&arg_wants, "debug-shell.service"); if (r < 0) return log_oom(); + + install_debug_shell_dropin(arg_dest); } r = generate_mask_symlinks();