1
0
mirror of https://github.com/systemd/systemd.git synced 2025-01-09 01:18:19 +03:00

meson: fix broken boolean kwarg

Everywhere else that `conf.get('ENABLE_*')` is used as a boolean key for
something (for example in if statements) it always checks if == 1, but
in this one case it neglects to do so. This is important because
conf.get yields the same int that was stored, but if statements require
booleans.

So does executable's "install" kwarg, at least according to the
documentation. In actuality, it accepts all types without sanity
checking, then uses python "if bool(var)", so you can actually do
`install: 'do not'` and that's treated identical to `true`. This is a
type-checking bug which Meson will eventually fix.

muon fails on the same code, today.
This commit is contained in:
Eli Schwartz 2022-07-26 21:49:48 -04:00 committed by Yu Watanabe
parent 89cdbe1f08
commit 9e4a50bcdf

View File

@ -2229,7 +2229,7 @@ exe = executable(
dependencies : [versiondep,
libseccomp],
install_rpath : rootpkglibdir,
install : conf.get('ENABLE_ANALYZE'))
install : conf.get('ENABLE_ANALYZE') == 1)
public_programs += exe
if want_tests != 'false'