From ae6fb82cd9b7d6cd5410fc670fd3c7f2eb22eae9 Mon Sep 17 00:00:00 2001 From: Ronan Pigott Date: Tue, 18 Jul 2023 16:52:18 -0700 Subject: [PATCH] zsh: remove unit property caching The existing caching policy isn't very sensible for this cache. We could write a different policy, but I don't think there is much value in caching these values, as in my experience the command used to generate them is quick. --- shell-completion/zsh/_systemctl.in | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/shell-completion/zsh/_systemctl.in b/shell-completion/zsh/_systemctl.in index 8c004c3bb1b..85ea6d28f57 100644 --- a/shell-completion/zsh/_systemctl.in +++ b/shell-completion/zsh/_systemctl.in @@ -451,13 +451,9 @@ done (( $+functions[_systemctl_unit_properties] )) || _systemctl_unit_properties() { - if ( [[ ${+_sys_all_properties} -eq 0 ]] || _cache_invalid SYS_ALL_PROPERTIES$_sys_service_mgr ) || - ! _retrieve_cache SYS_ALL_PROPERTIES$_sys_service_mgr; - then - _sys_all_properties=( ${${(M)${(f)"$({{ROOTLIBEXECDIR}}/systemd --dump-bus-properties)"}}} ) - _store_cache SYS_ALL_PROPERTIES$_sys_service_mgr _sys_all_properties - fi - _values -s , "${_sys_all_properties[@]}" + local -a _sys_all_properties=( ${(f)"$({{ROOTLIBEXECDIR}}/systemd --no-pager --dump-bus-properties 2>/dev/null)"} ) + _wanted systemd-unit-properties expl 'unit property' \ + _values -s , "${_sys_all_properties[@]}" } (( $+functions[_systemctl_job_modes] )) ||