shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2024-12-23 21:35:11 +03:00
Code

util: *DO NOT* loop for EINTR handling with close_nointr()

Browse Source 
See the linked references for why we should not do this.
This commit is contained in:
Colin Walters 2013-01-25 11:21:20 -05:00 committed by Lennart Poettering
parent 2a2473d89e
commit b0ee8068da
1 changed files with 17 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/shared/util.c
View File

@ -183,19 +183,26 @@ bool first_word(const char *s, const char *word) {
}
int close_nointr(int fd) {
assert(fd >= 0);
for (;;) {
int r;
assert(fd >= 0);
r = close(fd);
if (r >= 0)
return r;
if (errno != EINTR)
/* Just ignore EINTR; a retry loop is the wrong
* thing to do on Linux.
*
* http://lkml.indiana.edu/hypermail/linux/kernel/0509.1/0877.html
* https://bugzilla.gnome.org/show_bug.cgi?id=682819
* http://utcc.utoronto.ca/~cks/space/blog/unix/CloseEINTR
* https://sites.google.com/site/michaelsafyan/software-engineering/checkforeintrwheninvokingclosethinkagain
*/
if (_unlikely_(r < 0 && errno == EINTR))
return 0;
else if (r >= 0)
return r;
else
return -errno;
}
}
void close_nointr_nofail(int fd) {
int saved_errno = errno;