diff --git a/src/shared/async.c b/src/shared/async.c index bbb8b81011a..bd043c8484a 100644 --- a/src/shared/async.c +++ b/src/shared/async.c @@ -34,6 +34,28 @@ int asynchronous_sync(pid_t *ret_pid) { return 0; } +int asynchronous_fsync(int fd, pid_t *ret_pid) { + int r; + + assert(fd >= 0); + /* Same as asynchronous_sync() above, but calls fsync() on a specific fd */ + + r = safe_fork_full("(sd-fsync)", + /* stdio_fds= */ NULL, + /* except_fds= */ &fd, + /* n_except_fds= */ 1, + FORK_RESET_SIGNALS|FORK_CLOSE_ALL_FDS|(ret_pid ? 0 : FORK_DETACH), ret_pid); + if (r < 0) + return r; + if (r == 0) { + /* Child process */ + fsync(fd); + _exit(EXIT_SUCCESS); + } + + return 0; +} + /* We encode the fd to close in the userdata pointer as an unsigned value. The highest bit indicates whether * we need to fork again */ #define NEED_DOUBLE_FORK (1U << (sizeof(unsigned) * 8 - 1)) diff --git a/src/shared/async.h b/src/shared/async.h index 96148f9006e..2f5bbd51a52 100644 --- a/src/shared/async.h +++ b/src/shared/async.h @@ -20,6 +20,7 @@ * for avoiding threads. */ int asynchronous_sync(pid_t *ret_pid); +int asynchronous_fsync(int fd, pid_t *ret_pid); int asynchronous_close(int fd); int asynchronous_rm_rf(const char *p, RemoveFlags flags); diff --git a/src/shutdown/detach-dm.c b/src/shutdown/detach-dm.c index f6f672c75ad..bddd748d634 100644 --- a/src/shutdown/detach-dm.c +++ b/src/shutdown/detach-dm.c @@ -15,7 +15,7 @@ #include "devnum-util.h" #include "errno-util.h" #include "fd-util.h" -#include "sync-util.h" +#include "shutdown.h" typedef struct DeviceMapper { char *path; @@ -93,7 +93,6 @@ static int dm_list_get(DeviceMapper **head) { static int delete_dm(DeviceMapper *m) { _cleanup_close_ int fd = -EBADF; - int r; assert(m); assert(major(m->devnum) != 0); @@ -103,9 +102,11 @@ static int delete_dm(DeviceMapper *m) { if (fd < 0) return -errno; - r = fsync_path_at(AT_FDCWD, m->path); - if (r < 0) - log_debug_errno(r, "Failed to sync DM block device %s, ignoring: %m", m->path); + _cleanup_close_ int block_fd = open(m->path, O_RDONLY|O_CLOEXEC|O_NONBLOCK); + if (block_fd < 0) + log_debug_errno(errno, "Failed to open DM block device %s for syncing, ignoring: %m", m->path); + else + (void) sync_with_progress(block_fd); return RET_NERRNO(ioctl(fd, DM_DEV_REMOVE, &(struct dm_ioctl) { .version = { diff --git a/src/shutdown/detach-loopback.c b/src/shutdown/detach-loopback.c index 267509f7d02..8778a9e0c44 100644 --- a/src/shutdown/detach-loopback.c +++ b/src/shutdown/detach-loopback.c @@ -18,6 +18,7 @@ #include "detach-loopback.h" #include "device-util.h" #include "fd-util.h" +#include "shutdown.h" typedef struct LoopbackDevice { char *path; @@ -111,8 +112,7 @@ static int delete_loopback(const char *device) { /* Loopback block devices don't sync in-flight blocks when we clear the fd, hence sync explicitly * first */ - if (fsync(fd) < 0) - log_debug_errno(errno, "Failed to sync loop block device %s, ignoring: %m", device); + (void) sync_with_progress(fd); if (ioctl(fd, LOOP_CLR_FD, 0) < 0) { if (errno == ENXIO) /* Nothing bound, didn't do anything */ diff --git a/src/shutdown/detach-md.c b/src/shutdown/detach-md.c index ac46670f04f..b1aad976e57 100644 --- a/src/shutdown/detach-md.c +++ b/src/shutdown/detach-md.c @@ -17,6 +17,7 @@ #include "devnum-util.h" #include "errno-util.h" #include "fd-util.h" +#include "shutdown.h" #include "string-util.h" typedef struct RaidDevice { @@ -133,8 +134,7 @@ static int delete_md(RaidDevice *m) { if (fd < 0) return -errno; - if (fsync(fd) < 0) - log_debug_errno(errno, "Failed to sync MD block device %s, ignoring: %m", m->path); + (void) sync_with_progress(fd); return RET_NERRNO(ioctl(fd, STOP_ARRAY, NULL)); } diff --git a/src/shutdown/shutdown.c b/src/shutdown/shutdown.c index 03e6e70fd85..e6c9e0f8066 100644 --- a/src/shutdown/shutdown.c +++ b/src/shutdown/shutdown.c @@ -40,6 +40,7 @@ #include "process-util.h" #include "reboot-util.h" #include "rlimit-util.h" +#include "shutdown.h" #include "signal-util.h" #include "string-util.h" #include "switch-root.h" @@ -223,8 +224,10 @@ static int sync_making_progress(unsigned long long *prev_dirty) { return r; } -static int sync_with_progress(void) { +int sync_with_progress(int fd) { unsigned long long dirty = ULLONG_MAX; + _cleanup_free_ char *path = NULL; + const char *what; pid_t pid; int r; @@ -233,11 +236,20 @@ static int sync_with_progress(void) { /* Due to the possibility of the sync operation hanging, we fork a child process and monitor * the progress. If the timeout lapses, the assumption is that the particular sync stalled. */ - r = asynchronous_sync(&pid); - if (r < 0) - return log_error_errno(r, "Failed to fork sync(): %m"); + if (fd >= 0) { + r = asynchronous_fsync(fd, &pid); + if (r < 0) + return log_error_errno(r, "Failed to fork fsync(): %m"); - log_info("Syncing filesystems and block devices."); + (void) fd_get_path(fd, &path); + } else { + r = asynchronous_sync(&pid); + if (r < 0) + return log_error_errno(r, "Failed to fork sync(): %m"); + } + + what = path ?: "filesystems and block devices"; + log_info("Syncing %s.", what); /* Start monitoring the sync operation. If more than * SYNC_PROGRESS_ATTEMPTS lapse without progress being made, @@ -248,7 +260,7 @@ static int sync_with_progress(void) { /* Sync finished without error (sync() call itself does not return an error code) */ return 0; if (r != -ETIMEDOUT) - return log_error_errno(r, "Failed to sync filesystems and block devices: %m"); + return log_error_errno(r, "Failed to sync %s: %m", what); /* Reset the check counter if we made some progress */ if (sync_making_progress(&dirty) > 0) @@ -258,7 +270,8 @@ static int sync_with_progress(void) { /* Only reached in the event of a timeout. We should issue a kill to the stray process. */ (void) kill(pid, SIGKILL); return log_error_errno(SYNTHETIC_ERRNO(ETIMEDOUT), - "Syncing filesystems and block devices - timed out, issuing SIGKILL to PID "PID_FMT".", + "Syncing %s - timed out, issuing SIGKILL to PID "PID_FMT".", + what, pid); } @@ -432,7 +445,7 @@ int main(int argc, char *argv[]) { * desperately trying to sync IO to disk within their timeout. Do not remove this sync, data corruption will * result. */ if (!in_container) - (void) sync_with_progress(); + (void) sync_with_progress(-EBADF); disable_coredumps(); disable_binfmt(); @@ -600,7 +613,7 @@ int main(int argc, char *argv[]) { * which might have caused IO, hence let's do it once more. Do not remove this sync, data corruption * will result. */ if (!in_container) - (void) sync_with_progress(); + (void) sync_with_progress(-EBADF); notify_supervisor(); diff --git a/src/shutdown/shutdown.h b/src/shutdown/shutdown.h new file mode 100644 index 00000000000..99aaec697bf --- /dev/null +++ b/src/shutdown/shutdown.h @@ -0,0 +1,4 @@ +/* SPDX-License-Identifier: LGPL-2.1-or-later */ +#pragma once + +int sync_with_progress(int fd);