shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2025-02-01 09:47:35 +03:00
Code

udev: Fix "strtol" -> "strtoul" for unsigned source values

Browse Source
This commit is contained in:
Arseny Maslennikov 2018-09-18 13:01:46 +03:00
parent cdd63a03ce
commit b8e8823e63
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/udev/udev-builtin-net_id.c
View File

@ -246,7 +246,7 @@ static int dev_pci_onboard(struct udev_device *dev, struct netnames *names) {
/* kernel provided port index for multiple ports on a single PCI function */ /* kernel provided port index for multiple ports on a single PCI function */
attr = udev_device_get_sysattr_value(dev, "dev_port"); attr = udev_device_get_sysattr_value(dev, "dev_port");
if (attr) if (attr)
dev_port = strtol(attr, NULL, 10); dev_port = strtoul(attr, NULL, 10);
/* kernel provided front panel port name for multiple port PCI device */ /* kernel provided front panel port name for multiple port PCI device */
port_name = udev_device_get_sysattr_value(dev, "phys_port_name"); port_name = udev_device_get_sysattr_value(dev, "phys_port_name");
@ -312,7 +312,7 @@ static int dev_pci_slot(struct udev_device *dev, struct netnames *names) {
/* kernel provided port index for multiple ports on a single PCI function */ /* kernel provided port index for multiple ports on a single PCI function */
attr = udev_device_get_sysattr_value(dev, "dev_port"); attr = udev_device_get_sysattr_value(dev, "dev_port");
if (attr) { if (attr) {
dev_port = strtol(attr, NULL, 10); dev_port = strtoul(attr, NULL, 10);
/* With older kernels IP-over-InfiniBand network interfaces sometimes erroneously /* With older kernels IP-over-InfiniBand network interfaces sometimes erroneously
* provide the port number in the 'dev_id' sysfs attribute instead of 'dev_port', * provide the port number in the 'dev_id' sysfs attribute instead of 'dev_port',
* which thus stays initialized as 0. */ * which thus stays initialized as 0. */
@ -323,7 +323,7 @@ static int dev_pci_slot(struct udev_device *dev, struct netnames *names) {
if (type == ARPHRD_INFINIBAND) { if (type == ARPHRD_INFINIBAND) {
attr = udev_device_get_sysattr_value(dev, "dev_id"); attr = udev_device_get_sysattr_value(dev, "dev_id");
if (attr) if (attr)
dev_port = strtol(attr, NULL, 16); dev_port = strtoul(attr, NULL, 16);
} }
} }
} }