shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2025-02-04 21:47:31 +03:00
Code

tests: drop calls to unsetenv SYSTEMD_MEMPOOL

Browse Source 
Coverity was complaining that we don't check the return value, which we stopped
doing in 772e0a76f34914f6f81205e912e4744c6b23f704.

But it seems that we don't want those calls at all. The test was originally
added with the call in a6ee01caf3409ba9820e8824b9262fbac31a9f77, but I don't
see why we should override this. If the user wants to execute the test with
mempool disabled, we shouldn't ignore that.

Coverity CID#1444464, CID#1444466.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek 2021-03-25 12:19:18 +01:00
parent f1a8a66c35
commit bc52deda4b
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/libsystemd/sd-device/test-sd-device-thread.c
View File

@ -30,8 +30,6 @@ int main(int argc, char *argv[]) {
const char *key, *value;
int r;
unsetenv("SYSTEMD_MEMPOOL");
r = sd_device_new_from_syspath(&loopback, "/sys/class/net/lo");
if (r < 0)
return handle_error_errno(r, "Failed to create loopback device object");

2
src/libudev/test-udev-device-thread.c
View File

@ -28,8 +28,6 @@ int main(int argc, char *argv[]) {
pthread_t t;
int r;
unsetenv("SYSTEMD_MEMPOOL");
loopback = udev_device_new_from_syspath(NULL, "/sys/class/net/lo");
if (!loopback)
return handle_error_errno(errno, "Failed to create loopback device object");