shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2024-11-02 10:51:20 +03:00
Code

backlight: warn if kernel exposes backlight device with bogus max_brightness

Browse Source 
We shouldn't silently tape over broken kernel drivers.
This commit is contained in:
Lennart Poettering 2014-04-23 06:55:54 +02:00
parent e30fa16e27
commit c7fdf44d08
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/backlight/backlight.c
View File

@ -205,14 +205,18 @@ static unsigned get_max_brightness(struct udev_device *device) {
max_brightness_str = udev_device_get_sysattr_value(device, "max_brightness"); max_brightness_str = udev_device_get_sysattr_value(device, "max_brightness");
if (!max_brightness_str) { if (!max_brightness_str) {
log_warning("Failed to read 'max_brightness' attribute"); log_warning("Failed to read 'max_brightness' attribute.");
return 0; return 0;
} }
r = safe_atou(max_brightness_str, &max_brightness); r = safe_atou(max_brightness_str, &max_brightness);
if (r < 0) { if (r < 0) {
log_warning("Failed to parse 'max_brightness' \"%s\": %s", log_warning("Failed to parse 'max_brightness' \"%s\": %s", max_brightness_str, strerror(-r));
max_brightness_str, strerror(-r)); return 0;
}
if (max_brightness <= 0) {
log_warning("Maximum brightness is 0, ignoring device.");
return 0; return 0;
} }