shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2024-12-25 01:34:28 +03:00
Code

ethtool-util: disable autonegotiation when speed, duplex, or port is specified

Browse Source 
And if autonegotiation is enabled, speed, duplex, and port are ignored.

Fixes #19625.
This commit is contained in:
Yu Watanabe 2021-05-21 06:03:14 +09:00
parent 4323046c5f
commit c8e644b116
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/shared/ethtool-util.c
View File

@ -828,9 +828,16 @@ int ethtool_set_glinksettings(
* the speed is 0, %SPEED_UNKNOWN or the highest enabled speed and @duplex is %DUPLEX_UNKNOWN
* or the best enabled duplex mode. */
if (autonegotiation != AUTONEG_DISABLE && memeqzero(advertise, sizeof(uint32_t) * N_ADVERTISE)) {
log_debug("ethtool: autonegotiation is unset or enabled, the speed and duplex are not writable.");
return 0;
if (speed > 0 || duplex >= 0 || port >= 0) {
if (autonegotiation == AUTONEG_ENABLE || !memeqzero(advertise, sizeof(uint32_t) * N_ADVERTISE)) {
log_debug("ethtool: autonegotiation is enabled, ignoring speed, duplex, or port settings.");
speed = 0;
duplex = _DUP_INVALID;
port = _NET_DEV_PORT_INVALID;
} else {
log_debug("ethtool: setting speed, duplex, or port, disabling autonegotiation.");
autonegotiation = AUTONEG_DISABLE;
}
}
r = ethtool_connect(fd);