mirror of
https://github.com/systemd/systemd.git
synced 2024-12-22 17:35:35 +03:00
coccinelle: filter out a couple of 'false-positive' transformations
* flag-set.cocci: perform the transformation only if the second argument is a constant * sd-journal/lookup3.c: skip the cocci completely for this file, since it's not "ours" * strjoina.cocci: skip the transformation on the "test_strjoina" test, since it intentionally tests the "incorrect" expression we're trying to transform (the same thing was already done in strjoin.cocci)
This commit is contained in:
parent
57ac6959f5
commit
ca21d59a3f
@ -8,7 +8,8 @@ position p : script:python() {
|
||||
p[0].current_element == "log_set_max_level_realm" or
|
||||
p[0].current_element == "unichar_is_valid")
|
||||
};
|
||||
expression x, y;
|
||||
expression x;
|
||||
constant y;
|
||||
@@
|
||||
(
|
||||
- ((x@p) & (y)) == (y)
|
||||
|
@ -7,6 +7,7 @@ EXCLUDED_PATHS=(
|
||||
"src/basic/linux/*"
|
||||
# Symlinked to test-bus-vtable-cc.cc, which causes issues with the IN_SET macro
|
||||
"src/libsystemd/sd-bus/test-bus-vtable.c"
|
||||
"src/libsystemd/sd-journal/lookup3.c"
|
||||
)
|
||||
|
||||
top="$(git rev-parse --show-toplevel)"
|
||||
|
@ -1,6 +1,7 @@
|
||||
@@
|
||||
position p : script:python() { p[0].current_element != "test_strjoina" };
|
||||
expression n, m;
|
||||
expression list s;
|
||||
@@
|
||||
- n = strjoina(m, s, NULL);
|
||||
- n = strjoina@p(m, s, NULL);
|
||||
+ n = strjoina(m, s);
|
||||
|
Loading…
Reference in New Issue
Block a user