1
0
mirror of https://github.com/systemd/systemd.git synced 2024-10-30 14:55:37 +03:00

core/timer: fix memleak

Fixes #23326.
This commit is contained in:
Yu Watanabe 2022-05-10 14:09:24 +09:00 committed by Zbigniew Jędrzejewski-Szmek
parent 16f74783d8
commit d3ab7b8078

View File

@ -132,6 +132,7 @@ static int timer_add_trigger_dependencies(Timer *t) {
}
static int timer_setup_persistent(Timer *t) {
_cleanup_free_ char *stamp_path = NULL;
int r;
assert(t);
@ -145,13 +146,13 @@ static int timer_setup_persistent(Timer *t) {
if (r < 0)
return r;
t->stamp_path = strjoin("/var/lib/systemd/timers/stamp-", UNIT(t)->id);
stamp_path = strjoin("/var/lib/systemd/timers/stamp-", UNIT(t)->id);
} else {
const char *e;
e = getenv("XDG_DATA_HOME");
if (e)
t->stamp_path = strjoin(e, "/systemd/timers/stamp-", UNIT(t)->id);
stamp_path = strjoin(e, "/systemd/timers/stamp-", UNIT(t)->id);
else {
_cleanup_free_ char *h = NULL;
@ -160,14 +161,14 @@ static int timer_setup_persistent(Timer *t) {
if (r < 0)
return log_unit_error_errno(UNIT(t), r, "Failed to determine home directory: %m");
t->stamp_path = strjoin(h, "/.local/share/systemd/timers/stamp-", UNIT(t)->id);
stamp_path = strjoin(h, "/.local/share/systemd/timers/stamp-", UNIT(t)->id);
}
}
if (!t->stamp_path)
if (!stamp_path)
return log_oom();
return 0;
return free_and_replace(t->stamp_path, stamp_path);
}
static uint64_t timer_get_fixed_delay_hash(Timer *t) {