shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2024-12-25 01:34:28 +03:00
Code

firmware: fix possible segfault when firmware device goes away while loading

Browse Source 
Thanks to Ruediger Oertel.
This commit is contained in:
Kay Sievers 2010-03-16 10:57:44 +01:00
parent b41102757d
commit d44c27c5ab
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
extras/firmware/firmware.c
View File

@ -63,8 +63,10 @@ static bool copy_firmware(struct udev *udev, const char *source, const char *tar
if (fwrite(buf, size, 1, ftarget) == 1)
ret = true;
exit:
fclose(ftarget);
fclose(fsource);
if (ftarget != NULL)
fclose(ftarget);
if (fsource != NULL)
fclose(fsource);
free(buf);
return ret;
}
@ -178,7 +180,8 @@ int main(int argc, char **argv)
if (unlink(misspath) == 0)
util_delete_path(udev, misspath);
set_loading(udev, loadpath, "1");
if (!set_loading(udev, loadpath, "1"))
goto exit;
util_strscpyl(datapath, sizeof(datapath), udev_get_sys_path(udev), devpath, "/data", NULL);
if (!copy_firmware(udev, fwpath, datapath, statbuf.st_size)) {